change tolerance check on DiagonalGate to match UnitaryGate. #4375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you apply this to the new location for the diagonal gate in |
Cryoris
reviewed
May 21, 2020
Cryoris
reviewed
Jun 3, 2020
|
Could you add the same tolerance change to Then I think we can merge this. |
|
Yes can you deprecate the old location. It is leading to confusion. |
Yeah I'll open a PR for that 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a bug where it was possible to create a valid UnitaryGate which could be converted to an Isometry but would fail to decompose. The error was due to a difference in tolerances used for validating UnitaryGate and DiagonalGate.
Fixes #4369
Fixes #3842
Details and comments
In the case of UnitaryGate, numpy.allclose with atol=1e-8 and rtol=1e-5 was used while DiagonalGate used it's own implementation with a tolerance of 1e-10. This PR has DiagonalGate use numpy.allclose and references the same tolerances referenced by UnitaryGate.