-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Backend example #372
WIP Backend example #372
Conversation
@diego-plan9 I am worried about a few things before we accept this. Essentially as we move from the dictionary coupling_map to the list coupling_map we have some issues
So the fix i just did is try to do the convert very close to the mapper -- in the openquantumcompiler |
Its passing the test locally. To do
|
Update the test in order to specify the coupling_maps as lists, due to recent changes. Add a `test_compile_coupling_map_as_dict` that still uses the dict format, for backwards compatibility during the deprecation.
Along with other fixes to docstrings and tests.
Temporarily disable the osx build on Travis, as they are having a backlog that might take some time to recover: https://www.traviscistatus.com/incidents/qkqy13yk55q9
Thanks @jaygambetta for the quick and lean fix, and @ajavadia for picking up the missing coupling map! As discussed, I tweaked the tests and the docstrings, added an individual test to make sure we can still ensure that the functionality is working during the deprecation, and merging! |
* Fix for the quantum program with new backends * Fixing the tests * Small changes * Linting * Update tests using coupling_map as list, add test Update the test in order to specify the coupling_maps as lists, due to recent changes. Add a `test_compile_coupling_map_as_dict` that still uses the dict format, for backwards compatibility during the deprecation. * Update coupling_map as list related docstrings Along with other fixes to docstrings and tests. * Disable travis osx build temporarily (Qiskit#374) Temporarily disable the osx build on Travis, as they are having a backlog that might take some time to recover: https://www.traviscistatus.com/incidents/qkqy13yk55q9 * adding a missing coupling in test_quantumprogram
So Diego can see Fix for the quantum program with new backends Fixing the tests Small changes Linting Adding the qp to the compile section for completeness Doc changes naming Small changes Linting Small changes Moving the example WIP Backend example (Qiskit#372) * Fix for the quantum program with new backends * Fixing the tests * Small changes * Linting * Update tests using coupling_map as list, add test Update the test in order to specify the coupling_maps as lists, due to recent changes. Add a `test_compile_coupling_map_as_dict` that still uses the dict format, for backwards compatibility during the deprecation. * Update coupling_map as list related docstrings Along with other fixes to docstrings and tests. * Disable travis osx build temporarily (Qiskit#374) Temporarily disable the osx build on Travis, as they are having a backlog that might take some time to recover: https://www.traviscistatus.com/incidents/qkqy13yk55q9 * adding a missing coupling in test_quantumprogram
WIP Fix the coupling map to be a dictionary just before it goes to the mapper. The code is broken from #363.
Description
Changed the openquantumcompiler to convert to the dictionary to a list just before it is passed to the mapper. In the future the mapper will
Motivation and Context
Because we broke it in last pr
How Has This Been Tested?
running scripts will discuss below twst
Screenshots (if appropriate):
Types of changes
Checklist: