Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move barrier_before_final_measurements to 'passes' directory #3260

Merged
merged 5 commits into from
Oct 16, 2019
Merged

Move barrier_before_final_measurements to 'passes' directory #3260

merged 5 commits into from
Oct 16, 2019

Conversation

Matt-Stypulkoski
Copy link
Contributor

Summary

Implements the change in #3239's first note. Moves the barrier_before_final_measurements.py file from qiskit.transpiler.passes.mapping to qiskit.transpiler.passes

Details and comments

1ucian0
1ucian0 reviewed Oct 15, 2019
View reviewed changes
Copy link
Member

@1ucian0 1ucian0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an API change?

@kdk
Copy link
Member

kdk commented Oct 15, 2019 •
edited
Loading

Borderline, but I'm leaning towards no.

from qiskit.transpiler.passes import BarrierBeforeFinalMeasurements will still work.

from qiskit.transpiler.passes.mapping.barrier_before_final_measurements import BarrierBeforeFinalMeasurements and similar will stop working.

@1ucian0 1ucian0 added the Changelog: API Change Include in the "Changed" section of the changelog label Oct 16, 2019
@1ucian0 1ucian0 merged commit d3778ea into Qiskit:master Oct 16, 2019
faisaldebouni pushed a commit to faisaldebouni/qiskit-terra that referenced this pull request Aug 5, 2020
@Matt-Stypulkoski
Move barrier_before_final_measurements to 'passes' directory (Qiskit#…
b0bc619 
…3260)

* Move barrier_before_final_measurements to passes/ directory

* Edit import path of BarrierBeforeFinalMeasurements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ucian0 1ucian0 1ucian0 left review comments

@kdk kdk kdk approved these changes

@ajavadia ajavadia Awaiting requested review from ajavadia

@mtreinish mtreinish Awaiting requested review from mtreinish

Assignees
No one assigned
Labels
Changelog: API Change Include in the "Changed" section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Matt-Stypulkoski @kdk @1ucian0