Remove faer usage from quantum_volume #13714
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of Qiskit#13665 this migrates the faer-rs usage in quantum_volume.rs to just use nalgebra instead. The only faer usage there was for the qr decomposition and everything else was done with fixed sized arrays or Array2. This migration is fairly simple but it's a good start towards the goal of eventually removing our faer-rs usage in Qiskit. It might improve performance because we remove one layer of heap allocated objects by moving from Array2 to Matrix4 for rust operations. Although we do need an equivalent heap allocation for generating the numpy arrays used in `UnitaryGate` so it might not really change anything significantly.
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 13169712982Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
ElePT
approved these changes
Jan 31, 2025
|
This is largely duplicated in #13765 but I used nalgebra slightly differently in that PR (I forgot I had this PR open when I wrote it). I'm fine merging this as is, and just rebasing #13765 on top of this. Or we can just close this and move proceed solely with #13765. I'll defer to what you think is best @ElePT. |
|
This has been superseded by: #13765 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of #13665 this migrates the faer-rs usage in quantum_volume.rs to just use nalgebra instead. The only faer usage there was for the qr decomposition and everything else was done with fixed sized arrays or Array2. This migration is fairly simple but it's a good start towards the goal of eventually removing our faer-rs usage in Qiskit. It might improve performance because we remove one layer of heap allocated objects by moving from Array2 to Matrix4 for rust operations. Although we do need an equivalent heap allocation for generating the numpy arrays used in
UnitaryGateso it might not really change anything significantly.Details and comments
Part of #13665