Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing pulse-related deprecation #13392

Merged
merged 1 commit into from
Nov 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/circuit/src/dag_circuit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -888,6 +888,8 @@ impl DAGCircuit {
///
/// Raises:
/// Exception: if the gate is of type string and params is None.
///
/// DEPRECATED since Qiskit 1.3.0 and will be removed in Qiskit 2.0.0
#[pyo3(signature=(gate, qubits, schedule, params=None))]
fn add_calibration<'py>(
&mut self,
Expand Down
2 changes: 2 additions & 0 deletions qiskit/transpiler/passmanager_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,13 @@

from qiskit.transpiler.coupling import CouplingMap
from qiskit.transpiler.instruction_durations import InstructionDurations
from qiskit.utils.deprecate_pulse import deprecate_pulse_arg


class PassManagerConfig:
"""Pass Manager Configuration."""

@deprecate_pulse_arg("inst_map", predicate=lambda inst_map: inst_map is not None)
def __init__(
self,
initial_layout=None,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -412,21 +412,28 @@ def generate_preset_pass_manager(
"qubits_initially_zero": qubits_initially_zero,
}

if backend is not None:
pm_options["_skip_target"] = _skip_target
pm_config = PassManagerConfig.from_backend(backend, **pm_options)
else:
pm_config = PassManagerConfig(**pm_options)
if optimization_level == 0:
pm = level_0_pass_manager(pm_config)
elif optimization_level == 1:
pm = level_1_pass_manager(pm_config)
elif optimization_level == 2:
pm = level_2_pass_manager(pm_config)
elif optimization_level == 3:
pm = level_3_pass_manager(pm_config)
else:
raise ValueError(f"Invalid optimization level {optimization_level}")
with warnings.catch_warnings():
# inst_map is deprecated in the PassManagerConfig initializer
warnings.filterwarnings(
"ignore",
category=DeprecationWarning,
message=".*argument ``inst_map`` is deprecated as of Qiskit 1.3",
)
if backend is not None:
pm_options["_skip_target"] = _skip_target
pm_config = PassManagerConfig.from_backend(backend, **pm_options)
else:
pm_config = PassManagerConfig(**pm_options)
if optimization_level == 0:
pm = level_0_pass_manager(pm_config)
elif optimization_level == 1:
pm = level_1_pass_manager(pm_config)
elif optimization_level == 2:
pm = level_2_pass_manager(pm_config)
elif optimization_level == 3:
pm = level_3_pass_manager(pm_config)
else:
raise ValueError(f"Invalid optimization level {optimization_level}")
return pm


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ deprecations_transpiler:
* :class:`~qiskit.transpiler.passes.EchoRZXWeylDecomposition`
- |
The `inst_map` argument in :func:`~qiskit.transpiler.generate_preset_pass_manager`,
:meth:`~transpiler.target.Target.from_configuration` and :func:`~qiskit.transpiler.preset_passmanagers.common.generate_scheduling`
is being deprecated.
:meth:`~transpiler.target.Target.from_configuration`, :class:`~qiskit.transpiler.PassManagerConfig` initializer
and :func:`~qiskit.transpiler.preset_passmanagers.common.generate_scheduling` is being deprecated.
- |
The `calibration` argument in :func:`~qiskit.transpiler.target.InstructionProperties` initializer methods is being
deprecated.
Expand Down