Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove benchmarks for deprecated (or soon to be) features #13064

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

mtreinish
Copy link
Member

Summary

This commit removes benchmarks for the deprecated assemble module and the soon to be (see #13063) deprecated pulse module. While these features are still supported it's not worth the spending the limited CPU time we hacve on the benchmarking system to track the performance of these components anymore.

Details and comments

This commit removes benchmarks for the deprecated assemble module and
the soon to be (see Qiskit#13063) deprecated pulse module. While these
features are still supported it's not worth the spending the limited
CPU time we hacve on the benchmarking system to track the performance of
these components anymore.
@mtreinish mtreinish added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog labels Aug 30, 2024
@mtreinish mtreinish requested review from eggerdj, wshanks and a team as code owners August 30, 2024 21:46
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core
  • @nkanazawa1989

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10639545778

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.004%) to 89.148%

Files with Coverage Reduction New Missed Lines %
qiskit/synthesis/two_qubit/xx_decompose/decomposer.py 1 95.42%
crates/qasm2/src/lex.rs 3 92.73%
crates/qasm2/src/parse.rs 6 97.15%
Totals Coverage Status
Change from base Build 10638423704: 0.004%
Covered Lines: 71822
Relevant Lines: 80565

💛 - Coveralls

Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@mtreinish mtreinish added this pull request to the merge queue Sep 3, 2024
Merged via the queue into Qiskit:main with commit dde09f9 Sep 3, 2024
15 checks passed
sbrandhsn pushed a commit to sbrandhsn/qiskit that referenced this pull request Sep 5, 2024
This commit removes benchmarks for the deprecated assemble module and
the soon to be (see Qiskit#13063) deprecated pulse module. While these
features are still supported it's not worth the spending the limited
CPU time we hacve on the benchmarking system to track the performance of
these components anymore.
@mtreinish mtreinish deleted the drop-deprecated-benchmarks branch September 7, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants