Fix CSPLayout to ensure qubits in multi qubit gates are connected #12912
Conversation
|
|
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
|
Hi @ChilliPenguin, thanks for taking care of it. Can you @Silrem as a co-author? as you are based on their PR. I think enforcing the 3q-gate bidirectional when you dont know how the box is implemented makes sense. If it is a controlled-2q or a 2c-1q gate, maybe you can relax it? |
Summary
Adds more qubit connection requirements for CSPLayout to ensure 3+ qubit gates work correctly.
This fixes #7155 and is essentially just adding onto PR #7625 with slight modification and unit tests added.
Details and comments
This doesn't address the issue of directionality (specifically how should a connection between two control qubits be enforced if directionality matters)