Pin ahash to 0.8.6 #11499
Merged
Pin ahash to 0.8.6 #11499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent ahash release 0.8.7 started using the library feature 'stdsimd' which was not stabilized until Rust 1.72 for aarch64 and will cause an issue when building for aarch64 on (see tkaitchuck/aHash#195 for more details) with our MSRV which was 1.64 and was just raised to 1.70 in Qiskit#11493. This isn't caught in CI because we don't have any aarch64 environments to test with. As 1.72 is fairly recent < 6 months old as of this commit. This just opts to pin the ahash version used to one that is compatible with our MSRV on all supported platforms.
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 7425527945Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
ShellyGarion
pushed a commit
to ShellyGarion/qiskit-terra
that referenced
this pull request
Jan 18, 2024
The recent ahash release 0.8.7 started using the library feature 'stdsimd' which was not stabilized until Rust 1.72 for aarch64 and will cause an issue when building for aarch64 on (see tkaitchuck/aHash#195 for more details) with our MSRV which was 1.64 and was just raised to 1.70 in Qiskit#11493. This isn't caught in CI because we don't have any aarch64 environments to test with. As 1.72 is fairly recent < 6 months old as of this commit. This just opts to pin the ahash version used to one that is compatible with our MSRV on all supported platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The recent ahash release 0.8.7 started using the library feature 'stdsimd' which was not stabilized until Rust 1.72 for aarch64 and will cause an issue when building for aarch64 on (see tkaitchuck/aHash#195 for more details) with our MSRV which was 1.64 and was just raised to 1.70 in #11493. This isn't caught in CI because we don't have any aarch64 environments to test with. As 1.72 is fairly recent < 6 months old as of this commit. This just opts to pin the ahash version used to one that is compatible with our MSRV on all supported platforms.
Details and comments