Remove NoiseAdaptiveLayout and CrosstalkAdaptiveSchedule #11400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes two transpiler passes that are no longer useful in modern Qiskit. NoiseAdaptiveLayout has largely been superseded by VF2Layout and VF2PostLayout which takes noise into account for layout selection. The CrosstalkAdaptiveSchedule isn't usable anymore as it relies on custom fields being set to report cross talk in the BackendProperties payload for a BackendV1 instance. As most backends are using BackendV2 now and no current backends are reporting this custom field the pass can't be used.
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 7212955948Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
Dec 12, 2023
This commit deprecates two transpiler passes that are no longer useful in modern Qiskit. NoiseAdaptiveLayout has largely been superseded by VF2Layout and VF2PostLayout which takes noise into account for layout selection. The CrosstalkAdaptiveSchedule isn't usable anymore as it relies on custom fields being set to report cross talk in the BackendProperties payload for a BackendV1 instance. As most backends are using BackendV2 now and no current backends are reporting this custom field the pass can't be used. These transpiler passes will be removed in the 1.0.0 release (see Qiskit#11400).
jakelishman
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
I've removed some additional references to NoiseAdaptiveLayout in the benchmark and randomised test suites, and in the documentation about noise_adaptive.
This looks fine to merge to me - these two passes haven't been updated in ages, and are either no longer working at all, or completely superseded.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Deprecate NoiseAdaptiveLayout and CrosstalkAdaptiveSchedule This commit deprecates two transpiler passes that are no longer useful in modern Qiskit. NoiseAdaptiveLayout has largely been superseded by VF2Layout and VF2PostLayout which takes noise into account for layout selection. The CrosstalkAdaptiveSchedule isn't usable anymore as it relies on custom fields being set to report cross talk in the BackendProperties payload for a BackendV1 instance. As most backends are using BackendV2 now and no current backends are reporting this custom field the pass can't be used. These transpiler passes will be removed in the 1.0.0 release (see #11400). * Fix errant apostrophe * Fix black * Fix deprecation function calls * Catch deprecation warnings in tests * Fix lint --------- Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit removes two transpiler passes that are no longer useful in modern Qiskit. NoiseAdaptiveLayout has largely been superseded by VF2Layout and VF2PostLayout which takes noise into account for layout selection. The CrosstalkAdaptiveSchedule isn't usable anymore as it relies on custom fields being set to report cross talk in the BackendProperties payload for a BackendV1 instance. As most backends are using BackendV2 now and no current backends are reporting this custom field the pass can't be used.
Details and comments