Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Pulse model (#11215, #10694) #11348

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

TsafrirA
Copy link
Collaborator

Summary

With the development of the new pulse compiler, model and IR moving to a feature branch, this PR reverts PRs #11215 and #10694. The content will be moved to the feature branch.

Details and comments

Corrections to the Qubit references were not reverted.

@TsafrirA TsafrirA requested review from eggerdj, wshanks and a team as code owners November 30, 2023 12:50
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7046707898

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 17 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 87.414%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 5 92.17%
crates/qasm2/src/parse.rs 12 97.13%
Totals Coverage Status
Change from base Build 7039950767: -0.02%
Covered Lines: 59624
Relevant Lines: 68209

💛 - Coveralls

Copy link
Contributor

@nkanazawa1989 nkanazawa1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TsafrirA . Keeping the change of inter sphinx reference (.Qubit -> circuit.Qubit) looks reasonable.

Note that the feature branch still stays in Qiskit/qiskit (https://github.com/Qiskit/qiskit/tree/feature/pulse-ir); just a reference for people who may be interested in tracking this development. All related PRs will continue to appear in this repository which give us transparency of development, although this might create some noise in CI. The feature branch in Qiskit is not fully functional unless #11327 is merged and cherry-picked to feature/pulse-ir.

Merging this PR doesn't mean we give up implementation of #10759. The reverted pulse submodule (model) doesn't work at all until we introduce new pulse compiler, and the model module must be reverted not to introduce WIP objects in 1.0 prerelease. We plan to complete development with the feature branch, and new feature will be available with Qiskit 2.0 release. As far as I know this pattern is the first attempt in Qiskit, and protocol may change in future if we find this pattern doesn't fit in with the Qiskit standard.

@nkanazawa1989 nkanazawa1989 added this pull request to the merge queue Nov 30, 2023
Merged via the queue into Qiskit:main with commit c0702bf Nov 30, 2023
nkanazawa1989 added a commit that referenced this pull request Jan 18, 2024
nkanazawa1989 added a commit to nkanazawa1989/qiskit that referenced this pull request Feb 7, 2024
@TsafrirA TsafrirA deleted the RevertPulsePRs branch February 8, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants