-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue 11143 by removing deprecated code #11159
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Seemanta Bhattacharjee seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
ba73c40
to
cff661f
Compare
deprecations: | ||
- | | ||
The functions :func:`.num_to_latex_ket` and :func:`.numbers_to_latex_terms` | ||
have been removed. For similar functionality, see sympy's | ||
``nsimplify`` and ``latex`` functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deprecations: | |
- | | |
The functions :func:`.num_to_latex_ket` and :func:`.numbers_to_latex_terms` | |
have been removed. For similar functionality, see sympy's | |
``nsimplify`` and ``latex`` functions. | |
upgrade: | |
- | | |
The functions :func: `qiskit.visualization.state_visualization.num_to_latex_ket()` and | |
:func: `qiskit.visualization.state_visualization.numbers_to_latex_terms()` are deprecated. | |
For similar functionality, see sympy's `nsimplify` and `latex` functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@border-b You can not apply tag to PR, only maintainers can do that. (refer: github docs)
Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks
Pull Request Test Coverage Report for Build 6958019114
💛 - Coveralls |
* fixed issue 11143 by removing deprecated code * Update releasenotes/notes/fix_11143-d32a262538873a9d.yaml Co-authored-by: Luciano Bello <bel@zurich.ibm.com> --------- Co-authored-by: Luciano Bello <bel@zurich.ibm.com> Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
Summary
Fixes #11143
num_to_latex_ket
,numbers_to_latex_terms
functions fromqiskit/visualization/state_visualization.py
and also removed relevant tests.Details and comments
Please let me know if I've missed something. I am particularly not sure about the release note. Also, I don't know how to tag the PR as Changelog: Removal.