Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue 11143 by removing deprecated code #11159

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

border-b
Copy link
Contributor

Summary

Fixes #11143

  • Removed the num_to_latex_ket, numbers_to_latex_terms functions from qiskit/visualization/state_visualization.py and also removed relevant tests.
  • Removed some unused import calls from the 'qiskit/visualization/state_visualization.py` file.
  • Added a release note.

Details and comments

Please let me know if I've missed something. I am particularly not sure about the release note. Also, I don't know how to tag the PR as Changelog: Removal.

@border-b border-b requested review from nonhermitian, a team and ikkoham as code owners October 31, 2023 17:34
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Oct 31, 2023
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@CLAassistant
Copy link

CLAassistant commented Oct 31, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Seemanta Bhattacharjee seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Comment on lines 1 to 5
deprecations:
- |
The functions :func:`.num_to_latex_ket` and :func:`.numbers_to_latex_terms`
have been removed. For similar functionality, see sympy's
``nsimplify`` and ``latex`` functions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
deprecations:
- |
The functions :func:`.num_to_latex_ket` and :func:`.numbers_to_latex_terms`
have been removed. For similar functionality, see sympy's
``nsimplify`` and ``latex`` functions.
upgrade:
- |
The functions :func: `qiskit.visualization.state_visualization.num_to_latex_ket()` and
:func: `qiskit.visualization.state_visualization.numbers_to_latex_terms()` are deprecated.
For similar functionality, see sympy's `nsimplify` and `latex` functions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@border-b You can not apply tag to PR, only maintainers can do that. (refer: github docs)

@1ucian0 1ucian0 added the Changelog: Removal Include in the Removed section of the changelog label Nov 8, 2023
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks

@ElePT ElePT enabled auto-merge November 22, 2023 13:42
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6958019114

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.004%) to 86.457%

Files with Coverage Reduction New Missed Lines %
qiskit/visualization/array.py 2 87.5%
crates/qasm2/src/lex.rs 4 92.17%
Totals Coverage Status
Change from base Build 6951563267: -0.004%
Covered Lines: 66270
Relevant Lines: 76651

💛 - Coveralls

@ElePT ElePT added this pull request to the merge queue Nov 22, 2023
Merged via the queue into Qiskit:main with commit 98e1cc6 Nov 22, 2023
FabianBrings pushed a commit to FabianBrings/qiskit that referenced this pull request Nov 27, 2023
* fixed issue 11143 by removing deprecated code

* Update releasenotes/notes/fix_11143-d32a262538873a9d.yaml

Co-authored-by: Luciano Bello <bel@zurich.ibm.com>

---------

Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove deprecated code since 0.23 in qiskit/visualization/state_visualization.py
7 participants