Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requires_qe_access, deprecated in 0.17 #10823

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Sep 12, 2023

In 0.17 (released on April 01, 2021), the decorator requires_qe_access was deprecated. Time to remove it.

@1ucian0 1ucian0 requested a review from a team as a code owner September 12, 2023 16:41
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@1ucian0 1ucian0 added this to the 0.45.0 milestone Sep 12, 2023
Comment on lines 1 to 5
---
upgrade:
- |
The decorator `requires_qe_access` was deprecated in qiskit-terra 0.17 (released on April 2021)
and now is it being removed. The decorator :func:`.online_test` is a one-to-one replacement of it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh, the whole of qiskit.test should probably be private to Terra and not part of the public API. It's weird that other projects use our test internals that are really meant only for Terra.

online_test is only used for one test that shouldn't be part of Terra anyway.

(also: two backticks around requires_qe_access)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we should have done this a long time ago: #6862

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well good to see I'm self-consistent even if I didn't remember that - I'd already thumbs-ed up the issue haha

Copy link
Member Author

@1ucian0 1ucian0 Sep 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true... no need for reno. force of habit. removed in a2ba0ce

@1ucian0 1ucian0 added Changelog: Removal Include in the Removed section of the changelog Changelog: None Do not include in changelog and removed Changelog: Removal Include in the Removed section of the changelog labels Sep 14, 2023
@jakelishman jakelishman added this pull request to the merge queue Sep 22, 2023
Merged via the queue into Qiskit:main with commit 8867ff4 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants