-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove requires_qe_access
, deprecated in 0.17
#10823
Conversation
One or more of the the following people are requested to review this:
|
--- | ||
upgrade: | ||
- | | ||
The decorator `requires_qe_access` was deprecated in qiskit-terra 0.17 (released on April 2021) | ||
and now is it being removed. The decorator :func:`.online_test` is a one-to-one replacement of it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh, the whole of qiskit.test
should probably be private to Terra and not part of the public API. It's weird that other projects use our test internals that are really meant only for Terra.
online_test
is only used for one test that shouldn't be part of Terra anyway.
(also: two backticks around requires_qe_access
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree we should have done this a long time ago: #6862
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well good to see I'm self-consistent even if I didn't remember that - I'd already thumbs-ed up the issue haha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true... no need for reno. force of habit. removed in a2ba0ce
In 0.17 (released on April 01, 2021), the decorator
requires_qe_access
was deprecated. Time to remove it.