Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate
qiskit.extensions
#10725Deprecate
qiskit.extensions
#10725Changes from all commits
29cc524
9e000bb
1afc35c
5fe1a8b
4ffea01
ec48a1b
90ffaf2
3a988da
dd47bde
f9112a3
26e0683
5f672b7
53991db
30f787a
1503f06
ee7d4d3
9d8915b
0f97a95
1013c38
1e7c72e
7b09ab4
3e92ab3
1accd97
80ace24
e2e7807
4bd902b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this in conjunction with all the rest of the work on removing uses of
qiskit.extensions
actually was a bit of a breaking change, becauseqiskit.extensions
is no longer available just by having doneimport qiskit
. In other words:would have worked without error before, and now it'll say
and require you to do
import qiskit.extensions
.That's minor and we can probably get away with it, but it was a dedicated submodule that was previously automatically imported, so just pointing out that these removals can cause issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would've liked to deprecate this as the
Diagonal
circuit exists, butDiagonalGate
seems to be used in the Aer simulators.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo it should be the circuit that gets removed not the gate, since circuits inherently define an eager synthesis, but that's not important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, maybe this would best be part of an overhaul to consistently use Gate or Circuits (probably the first) 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this is quite confusing. Maybe it's worth to add a comment somewhere about the difference between them, and which one will be deprecated?
(although we also have
Permutation
andPermutationGate
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we had the plans to deprecate
Permutation
circuit oncePermutationGate
is around. Do you think it's a good idea?