Add Expr support in DAGCircuit.substitute_node
#10382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 5604254441
💛 - Coveralls |
As part of this minor refactor, this updates the logic to no longer silently override conditions on the replacement `op`. The method gains a `propagate_condition` argument analogous to the same argument in `substitute_node_with_dag`, which can be set `False` to specify that the caller is aware that the new operation should implement the same conditional logic.
e70058f to
60cd949
Compare
|
Rebased on |
mtreinish
reviewed
Jul 19, 2023
| current_wires = {wire for _, _, wire in self.edges(node)} | ||
| new_wires = set(node.qargs) | set(node.cargs) | ||
| if (new_condition := getattr(op, "condition", None)) is not None: | ||
| new_wires.update(condition_resources(new_condition).clbits) |
There was a problem hiding this comment.
Is there a mapping or check that needs to be done here to ensure op.condition exists in the dag already?
There was a problem hiding this comment.
If you mean the wires, it happens lower down, I think: https://github.com/Qiskit/qiskit-terra/blob/60cd949fc41915c1a12fb8faa3e4c1ea3e6f94b5/qiskit/dagcircuit/dagcircuit.py#L1331-L1337.
(Looks like there might be a comment that's out of date there though haha!)
There was a problem hiding this comment.
Ah, yeah that'll do it. It just slipped my mental context that this would validate wires.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of this minor refactor, this updates the logic to no longer silently override conditions on the replacement
op. The method gains apropagate_conditionargument analogous to the same argument insubstitute_node_with_dag, which can be setFalseto specify that the caller is aware that the new operation should implement the same conditional logic.Details and comments
Close #10380. Depends on #10377. This has a partial changelog of itself, but the rest is coming in #10331.