Add Expr support to QuantumCircuit.compose
#10375
Conversation
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 5598447243
💛 - Coveralls |
This relatively straightforwardly generalises the mapping of variables that already exists in `QuantumCircuit.compose` to be able to handle arbitrary `Expr` nodes as well. We must take care not to accidentally mutate the `Expr` nodes in the input circuit in the name of efficiency.
3d77997 to
9d540d1
Compare
|
Rebased over |
| def visit_value(self, node, /): | ||
| return expr.Value(node.value, node.type) | ||
|
|
||
| def visit_unary(self, node, /): | ||
| return expr.Unary(node.op, node.operand.accept(self), node.type) | ||
|
|
||
| def visit_binary(self, node, /): | ||
| return expr.Binary(node.op, node.left.accept(self), node.right.accept(self), node.type) | ||
|
|
||
| def visit_cast(self, node, /): | ||
| return expr.Cast(node.operand.accept(self), node.type, implicit=node.implicit) |
There was a problem hiding this comment.
Perhaps it wouldn't really come up again, but if it does, it might make sense to have a transformer base class specific for expr.Expr that has default implementations like this.
There was a problem hiding this comment.
You mean like a subclass of ExprVisitor that (by default) copies the structure by producing the exact same Expr, but visiting each child node, with the intention that a consumer overrides only the behaviour they need?
I could potentially see that being useful, yeah - I'd maybe like to wait to see if we have other use-cases for it first, before adding more API surface.
There was a problem hiding this comment.
Yeah, exactly 😄. Totally agree, makes sense to wait.
Summary
This relatively straightforwardly generalises the mapping of variables that already exists in
QuantumCircuit.composeto be able to handle arbitraryExprnodes as well. We must take care not to accidentally mutate theExprnodes in the input circuit in the name of efficiency.Details and comments
Resolve #10227. Depends on #10359. Changelog to come in #10331.