🏗️ IBM Cloud Integration #1593
Draft
🏗️ IBM Cloud Integration #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* created the ibm_cloud service to authenticate with * preparing the tests * added tests for ibm cloud authentication process * fix lint * fix authentication logger
* mock backend renamed * created local service * added the channel as a parameter in the use case * improved the tests to verify permissions in groups * fix bug creating the provider
* Channel implementation in client * fix bug with settings configuration * use get_headers in serverless client * get_headers as static method * include instance in files client * move get_headers to all the requests * moved get_headers to utils * updated docstrings * added the same param to ibm serverless client
* fixed a bug in the client uploading functions * setup channel and instance in the env vars * updated references to old env vars * use the new env vars in the client * fix test * fix lint and black * fix tests * fix enum value * tests updated * fix black and lint
* improve logic with authentication failed exception * fix linter * implement the headers for 401 exception * Empty commit
# Conflicts: # client/qiskit_serverless/core/clients/serverless_client.py
|
Last thing remains, we just need to save the id from the access group instead the name and add account id into groups if it's possible. |
* fix: IBMServerlessClient save_account * fix lint * fix docstring * apply partial review suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces a series of improvements and optimizations across various components of the authentication and service integration modules.
The most important new feature is the possibility to authenticate with IBM Cloud. This way we have three different channels:
The first are the channels we were using until now and this PR doesn't add any breaking change on those features. IBM Cloud authentication will need to use the new interface:
The rest of the channels, IBM Quantum and Local, remain the same with the exception that now you would have two ways to authenticate:
Important
instanceparameter will be used only for IBM Cloud crn.