Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to every module in API index page (cherry-pick of #1649) #1650

Merged
merged 1 commit into from
May 2, 2024

Conversation

Eric-Arellano
Copy link
Collaborator

Before, qiskit_ibm_runtime.transpiler.passes.scheduling was autogenerated by autosummary rather than being manually created like we normally do in apidocs/. This had two issues:

  1. The module does not show up in the API index page https://docs.quantum.ibm.com/api/qiskit-ibm-runtime, even though it shows up as top-level in the doc app's left table of contents
  2. The header hierarchy is messed up due to an autosummary quirk that I could not figure out Fix unnecessary h1 header in module pages generated by autosummary documentation#1272

Using a dedicated page fixes both of these problems.

I named the file qiskit_ibm_runtime.transpiler.passes.scheduling.rst to preserve the previous URL we had for the module. (Technically, Sphinx now puts the HTML file in the apidocs/ folder rather than stubs/, but the docs app doesn't care.)

This PR also removes the override of the module.rst template. We shouldn't end up using it anymore. Regardless, our version is out-of-date compared with the default and we didn't have any substantial changes.

Before, `qiskit_ibm_runtime.transpiler.passes.scheduling` was autogenerated by `autosummary` rather than being manually created like we normally do in `apidocs/`. This had two issues:

1. The module does not show up in the API index page https://docs.quantum.ibm.com/api/qiskit-ibm-runtime, even though it shows up as top-level in the doc app's left table of contents
2. The header hierarchy is messed up due to an autosummary quirk that I could not figure out Qiskit/documentation#1272

Using a dedicated page fixes both of these problems.

I named the file `qiskit_ibm_runtime.transpiler.passes.scheduling.rst` to preserve the previous URL we had for the module. (Technically, Sphinx now puts the HTML file in the `apidocs/` folder rather than `stubs/`, but the docs app doesn't care.)

This PR also removes the override of the `module.rst` template. We shouldn't end up using it anymore. Regardless, our version is out-of-date compared with the default and we didn't have any substantial changes.
@Eric-Arellano Eric-Arellano requested a review from kt474 May 2, 2024 12:54
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8924186814

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.619%

Totals Coverage Status
Change from base Build 8910317115: 0.0%
Covered Lines: 6248
Relevant Lines: 7472

💛 - Coveralls

@kt474 kt474 merged commit 7b2e232 into Qiskit:stable/0.23 May 2, 2024
20 checks passed
@Eric-Arellano Eric-Arellano deleted the cp-no-module branch May 2, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants