Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Check for faulty qubits and edges #571

Merged
merged 4 commits into from
Apr 7, 2023
Merged

Check for faulty qubits and edges #571

merged 4 commits into from
Apr 7, 2023

Conversation

jyu00
Copy link
Collaborator

@jyu00 jyu00 commented Apr 6, 2023

Summary

Closes #568

Checks if the input circuits use a faulty qubit or edge and raises if they do.

Details and comments

@jyu00 jyu00 requested a review from kt474 April 6, 2023 21:31
@jyu00 jyu00 added the Changelog: New Feature Include in the Added section of the changelog label Apr 6, 2023
@coveralls
Copy link

coveralls commented Apr 6, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4638459525

  • 18 of 20 (90.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 50.245%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_provider/ibm_backend.py 18 20 90.0%
Totals Coverage Status
Change from base Build 4630070031: 0.3%
Covered Lines: 2975
Relevant Lines: 5921
💛 - Coveralls

kt474
kt474 approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@kt474 kt474 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

blakejohnson
blakejohnson suggested changes Apr 7, 2023
View reviewed changes
Copy link

@blakejohnson blakejohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the skip_transpilation check.

@blakejohnson blakejohnson merged commit 3aa44ac into Qiskit:main Apr 7, 2023
@jyu00 jyu00 deleted the check-faulty branch April 12, 2023 15:15
@kt474 kt474 added this to the 0.5.2 milestone Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blakejohnson blakejohnson blakejohnson approved these changes

@kt474 kt474 kt474 approved these changes

Assignees

@jyu00 jyu00

Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Milestone
0.5.2
Development

Successfully merging this pull request may close these issues.

Provider should raise early if circuit uses faulty qubits or gates
4 participants
@jyu00 @coveralls @blakejohnson @kt474