enable c_if for reset and raise exception if instruction does not support c_if
#1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhorii
commented
Jul 11, 2023
qiskit_aer/backends/aer_compiler.py
Outdated
| elif name == "diagonal": | ||
| _check_no_conditional(name, conditional_reg) |
There was a problem hiding this comment.
Maybe we can support c_if for diagonal as well as reset.
| aer_circ.diagonal(qubits, params, label if label else "diagonal") | ||
| elif name == "unitary": | ||
| aer_circ.unitary(qubits, params[0], conditional_reg, label if label else "unitary") | ||
| elif name == "pauli": | ||
| aer_circ.gate(name, qubits, [], params, conditional_reg, label if label else name) | ||
| elif name == "initialize": | ||
| _check_no_conditional(name, conditional_reg) |
There was a problem hiding this comment.
I think initialize should not support c_if as well as set_* and save_*
eac126e to
7d297dd
Compare
doichanj
approved these changes
Oct 10, 2023
doichanj
pushed a commit
to doichanj/qiskit-aer
that referenced
this pull request
Oct 26, 2023
…upport `c_if` (Qiskit#1868) * enable c_if for reset and raise exception if instruction does not support c_if * add reno * use correct conditional_reg for reset * support c_if for diagonal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #1865
Details and comments
Enable
c_ifforresetinstructions.Raise an exception if
c_ifis called for an instruction that does not supportc_if.