Fix test deprecation warnings and call parent's setUpClass #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Qiskit/qiskit#6753 the base test classes were fixed to assert that setUp and setUpClass in the base test class are always called. This is necessary to ensure that all the warning assertions always work. However this change had the unintended side effect of causing Aer's CI to fail because it wasn't calling super().setUpClass(). This commit makes this change to fix that failure. However, because now we're running enforcement that tests can't raise unhandled DeprecationWarnings a few spots in the tests were emitting deprecation warnings. The deprecated syntax is either fixed or if it's testing something in Aer that's deprecated an assertion on that warning is added to fix the failure.
jakelishman
reviewed
Aug 4, 2021
There was a problem hiding this comment.
Ideally we should work out the split properly, so Aer doesn't need to derive its test class from Terra-specific functionality, but that's something to work out on the Terra side first.
One question about a test that's dropped out of a loop, though it looks like it still belongs in it?
4206ef7 to
bc99512
Compare
jakelishman
approved these changes
Aug 4, 2021
|
Oh wait, I have no power on Aer. Still, you can have a symbolic tick, if not a meaningful one. |
chriseclectic
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In Qiskit/qiskit#6753 the base test classes were fixed to assert
that setUp and setUpClass in the base test class are always called. This
is necessary to ensure that all the warning assertions always work.
However this change had the unintended side effect of causing Aer's CI
to fail because it wasn't calling super().setUpClass(). This commit
makes this change to fix that failure. However, because now we're
running enforcement that tests can't raise unhandled
DeprecationWarnings a few spots in the tests were emitting deprecation
warnings. The deprecated syntax is either fixed or if it's testing
something in Aer that's deprecated an assertion on that warning is added
to fix the failure.
Details and comments