Handle some floating point edge cases in truncation #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caleb-johnson
commented
Mar 5, 2025
| @@ -168,7 +168,9 @@ def truncate_binary_search( | |||
| lower_error = 0.0 | |||
|
|
|||
| # binary search for a cutoff threshold | |||
| while ((upper_threshold - lower_threshold) > 1e-10) and (upper_error != lower_error): | |||
| while ((upper_threshold - lower_threshold) > 1e-10) and not ( | |||
| np.isclose(upper_error, lower_error) | |||
There was a problem hiding this comment.
default atol is 1e-8, @BryceFuller , @mrossinek . Is that fine? We don't take a tolerance to this func as input
There was a problem hiding this comment.
It seems a bit arbitrary to me, to mix the 1e-10 threshold in the first statement with an atol=1e-8 and rtol=1e-5 in np.isclose. If we could unify that and maybe even expose it as a setting that would be better imo
There was a problem hiding this comment.
@BryceFuller and I are also trying to determine if we need both while conditionals here. Need to think on it a bit before finishing this up
Pull Request Test Coverage Report for Build 13680724529Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.