Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed coral sell & added allowSwimming Ox_lib boolean to progressbar #31

Merged
merged 7 commits into from
Apr 21, 2024
Merged

Fixed coral sell & added allowSwimming Ox_lib boolean to progressbar #31

merged 7 commits into from
Apr 21, 2024

Conversation

IN1GHTM4R3
Copy link
Contributor

@IN1GHTM4R3 IN1GHTM4R3 commented Apr 9, 2024 •
edited
Loading

Description

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

@IN1GHTM4R3
Update main.lua
489ccc9 
fixed the sell of coral feature
@IN1GHTM4R3
Update README.md
0230285 
added ox_lib changes to make underwater progress bar feature to work
@mafewtm
Copy link
Member

mafewtm commented Apr 9, 2024 •
edited
Loading

Instead of instructing the user to comment out a line of ox_lib, we should just be adding allowSwimming = true to the progress bars. Additionally, you don't need to add a comment in the code explaining why its being done. That's what the description of this PR is for

@IN1GHTM4R3
Update README.md
f042eb5
@IN1GHTM4R3
Update main.lua
302069e 
added allowSwimming = true, to progress bar function for coral collection.
@IN1GHTM4R3
Copy link
Contributor Author

Ok @mafewtm should be fixed now based on the above.

@IN1GHTM4R3 IN1GHTM4R3 changed the title Fixed coral sell & added read.me for allowing underwater ox_targeting of coral for harvesting Fixed coral sell & added allowSwimming Ox_lib boolean to progressbar Apr 9, 2024
Manason
Manason suggested changes Apr 9, 2024
View reviewed changes
server/main.lua Outdated Show resolved Hide resolved
@Manason Manason merged commit 9f427ea into Qbox-project:main Apr 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manason Manason Manason approved these changes

@mafewtm mafewtm mafewtm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IN1GHTM4R3 @mafewtm @Manason