Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package organization #95

Merged
merged 17 commits into from
Apr 22, 2022
Merged

Conversation

osopardo1
Copy link
Member

@osopardo1 osopardo1 commented Mar 29, 2022

Description

This PR organizes the information in build.sbt and solves different problems to publish packages.

Right now, the publication of releases has to be manual. We did not set up any workflow to do so because we don't have a clear pipeline for managing the versions at this moment. Another reason is that only maintainers with the corresponding credentials are in charge of publishing the package, so not everyone can manage Sonatype and Nexus Repository.

If you want to know more about publishing and artifacts, go to our Qbeast Pills post about the topic!

Type of change

Describe the change you're making: how it affects the API, user experience...

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • Documentation update

Checklist:

Here is the list of things you should do before submitting this pull request:

  • New feature / bug fixed
  • Add comments to the code
  • Change the documentation
  • Add tests
  • Dependent changes are merged

#	build.sbt
Separate settings between common, release, and publishGithub

Add logic to release SNAPSHOT versions

Add qbeast-core:0.1.0 dependency
@osopardo1 osopardo1 requested a review from eavilaes March 29, 2022 15:37
@eavilaes
Copy link
Contributor

For some reason I can not run sbt clean on the root project qbeastSpark:

java.lang.IllegalArgumentException: Cannot add dependency 'io.qbeast#qbeast-core_2.12;0.1.0' to configuration 'assembly' of module io.qbeast#qbeast-spark_2.12;0.2.0 because this configuration doesn't exist!

As far as I have seen, it has to do something with this line, but I'm not an expert in sbt (yet) 🙃:

.dependsOn(qbeastCore % "test->test;compile->compile;assembly->assembly")

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #95 (5fdbf07) into main (f146d92) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   89.34%   89.34%           
=======================================
  Files          60       60           
  Lines        1286     1286           
  Branches      100      100           
=======================================
  Hits         1149     1149           
  Misses        137      137           
Impacted Files Coverage Δ
...e/src/main/scala/io/qbeast/core/model/CubeId.scala 96.25% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f146d92...5fdbf07. Read the comment docs.

@osopardo1
Copy link
Member Author

For some reason I can not run sbt clean on the root project qbeastSpark:

java.lang.IllegalArgumentException: Cannot add dependency 'io.qbeast#qbeast-core_2.12;0.1.0' to configuration 'assembly' of module io.qbeast#qbeast-spark_2.12;0.2.0 because this configuration doesn't exist!

As far as I have seen, it has to do something with this line, but I'm not an expert in sbt (yet) upside_down_face:

.dependsOn(qbeastCore % "test->test;compile->compile;assembly->assembly")

Solved!

@cugni cugni self-requested a review March 30, 2022 12:36
build.sbt Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
@osopardo1 osopardo1 self-assigned this Mar 31, 2022
build.sbt Outdated Show resolved Hide resolved
build.sbt Show resolved Hide resolved
@osopardo1
Copy link
Member Author

In the end, the Codecov still failing... can we fix that? Any ideas? @eavilaes

Once it's done I think we can merge 👍

@eavilaes
Copy link
Contributor

eavilaes commented Apr 1, 2022

In the end, the Codecov still failing... can we fix that? Any ideas? @eavilaes

Once it's done I think we can merge 👍

I opened a PR in my fork to test merging and try to fix the problem: eavilaes#6.
It seems that Codecov is skipping qbeastCore project at some point, but still looking at it.

Edit: As per Codecov docs it should work automatically merging coverage reports.

This reverts commit 7affce4.
We found a problem with Codecov coverage, so we are reverting this commit until we find a solution.
@eavilaes
Copy link
Contributor

eavilaes commented Apr 4, 2022

As Codecov was not merging the reports correctly when we split the tests, we are reverting 7affce4 in 3851146. Once the tests pass, we can merge👍🏼

@osopardo1 osopardo1 requested a review from cugni April 4, 2022 09:33
@osopardo1 osopardo1 merged commit 55442d9 into Qbeast-io:main Apr 22, 2022
@osopardo1 osopardo1 deleted the package-organization branch April 22, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants