-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package organization #95
Conversation
# build.sbt
Separate settings between common, release, and publishGithub Add logic to release SNAPSHOT versions Add qbeast-core:0.1.0 dependency
It is not needed since the publish is done manually
For some reason I can not run
As far as I have seen, it has to do something with this line, but I'm not an expert in sbt (yet) 🙃: Line 17 in ecc6ecf
|
Codecov Report
@@ Coverage Diff @@
## main #95 +/- ##
=======================================
Coverage 89.34% 89.34%
=======================================
Files 60 60
Lines 1286 1286
Branches 100 100
=======================================
Hits 1149 1149
Misses 137 137
Continue to review full report at Codecov.
|
Solved! |
In the end, the Codecov still failing... can we fix that? Any ideas? @eavilaes Once it's done I think we can merge 👍 |
I opened a PR in my fork to test merging and try to fix the problem: eavilaes#6. Edit: As per Codecov docs it should work automatically merging coverage reports. |
This reverts commit 7affce4. We found a problem with Codecov coverage, so we are reverting this commit until we find a solution.
Description
This PR organizes the information in
build.sbt
and solves different problems to publish packages.Right now, the publication of releases has to be manual. We did not set up any workflow to do so because we don't have a clear pipeline for managing the versions at this moment. Another reason is that only maintainers with the corresponding credentials are in charge of publishing the package, so not everyone can manage Sonatype and Nexus Repository.
If you want to know more about publishing and artifacts, go to our Qbeast Pills post about the topic!
Type of change
Describe the change you're making: how it affects the API, user experience...
Checklist:
Here is the list of things you should do before submitting this pull request: