-parallel-scenarios flag support added #21
Conversation
|
Thank you for taking the time of implementing this. It's something I wanted to do as well. I wonder if this should not be a separate flag. Some servers don't support parallel connections unfortunately. For the live instance of QUIC-Tracker I would like to keep the test runs scheduling as is. Could you add a flag to enable your changes ? Something like "-parallel-scenarios" ? |
|
In the case where the servers don't support parallel connections, the parallel flag would be set to false which in turn would set the maxInstances value to 1. As a result, the semaphore channel would only allow one execution at a time. |
|
Yes but there could be an interest in enabling the same scenario to be run accross differents hosts, as it is now based on the file provided in the repo. And not enabling several scenarios to be run at the same time for a particular server ensures that single-connection servers are supported. Those are rarer these days actually. |
|
Oh, I understand. I'll try adding support for a "-parallel-scenarios" flag then. |
|
I've added support for the -parallel-scenarios flag. I think it should work well for both the cases we discussed above now. Please do let me know if you feel something should be changed. |
This allows multiple scenarios to be executed in parallel against multiple hosts, not just the same scenario against multiple hosts in parallel.
Before this, if the hosts.txt file contained just one host, all the scenarios would execute sequentially even if the machine is capable of supporting parallel execution. As a result, executing test_suite.go would take much more time as compared to allowing multiple scenarios to execute in parallel.
Creating a local copy of the iterator variable i.e. scenarioId:= id, ensures that the different iterations of scenarios being executed in parallel remain independent of each other.