Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quicklook popup broken after upgrading to Windows 11 #955

Closed
prakharb5 opened this issue Jul 11, 2021 · 38 comments
Closed

Quicklook popup broken after upgrading to Windows 11 #955

prakharb5 opened this issue Jul 11, 2021 · 38 comments

Comments

@prakharb5
Copy link

Describe the bug

After upgrading to Windows 11 Dev Insider, I noticed that the Quicklook popup is very buggy. It takes a long time for displaying info and previews correctly. Even the buttons on the top left and top right look weird. Plus, the cursor starts having a laggy motion when the popup is open.

I also noticed that this bug only happened when the quicklook popup was opened from File explorer. When i tried quicklook-ing a file on my Desktop, the popup opened just normally.

To Reproduce

Steps to reproduce the behavior:

  1. Upgrade to Win11 Dev insider from Win10
  2. Try opening quicklook for a folder or an image
  3. See error

Expected behavior

The quicklook popup should properly display the information and/or image normally.

Desktop (please complete the following information):

  • OS Version: Windows 11 Dev Insider 22000.65
  • QuickLook Version: 3.6.11 from MS Store

Screenshots and Exception Log

image

image

8mb.video-rXz-vSgVcL3D.mp4
@xupefei
Copy link
Member

xupefei commented Jul 12, 2021

I tend to believe it's a Windows bug. I'll wait for a few more builds before spending time fixing it.

@Y4shSHD
Copy link

Y4shSHD commented Jul 15, 2021

I tend to believe it's a Windows bug. I'll wait for a few more builds before spending time fixing it.

Even I believe it's a Windows 11 Problem. Because as I "preview" my files, and keep QL on top, then drag the currently open window, the movement lags a LOT!

Check the screen recording attached, you'll understand what I am saying!

Capture.mp4

@ikas-mc
Copy link

ikas-mc commented Jul 16, 2021

It's not just quicklook that has this problem.
It may be caused by the windows11's rendering of blur.
Turning off the system transparency and turning off the App blur effect can temporarily solve the problem.
Test on 22000.71

@Masterlovsky
Copy link

When I open a folder, quicklook render like this... Something wrong happend on system win11?
Snipaste_2021-07-18_16-50-23

@Marocco2
Copy link

It's not just quicklook that has this problem.
It may be caused by the windows11's rendering of blur.
Turning off the system transparency and turning off the App blur effect can temporarily solve the problem.
Test on 22000.71

How did you disable app blur effect? Disabling via system setting won't fix the problem

@ikas-mc
Copy link

ikas-mc commented Jul 18, 2021

@Marocco2
You need to modify the code and then build

WindowHelper.EnableBlur(this);

@Marocco2
Copy link

@Marocco2
You need to modify the code and then build

WindowHelper.EnableBlur(this);

Thanks, gonna try it ASAP

@rabelux rabelux mentioned this issue Jul 23, 2021
@ikas-mc
Copy link

ikas-mc commented Jul 24, 2021

The api [SetWindowCompositionAttribute] is broken on win10(1903+) and win11, maybe we need to stop using this api, or add a option to disable blur...
It will not only cause problems in the app itself, but also cause problems in other windows
sourcechord/FluentWPF#42
File-New-Project/EarTrumpet#349
@xupefei

@prakharb5
Copy link
Author

or add a option to disable blur

i am in total support for adding option to disable blur.

@Stem-LG
Copy link

Stem-LG commented Jul 25, 2021

this doesn't happen using Files, I suggest using it as an alternative until microsoft provides a fix

@ikas-mc
Copy link

ikas-mc commented Jul 26, 2021

this doesn't happen using Files, I suggest using it as an alternative until microsoft provides a fix

Files use win32 host a standard uwp project,so files does not use the internal api...

@ghost
Copy link

ghost commented Jul 26, 2021

@Marocco2
You need to modify the code and then build

WindowHelper.EnableBlur(this);

Can u tell me how to do that??

@rabelux
Copy link
Member

rabelux commented Jul 26, 2021

@Marocco2
You need to modify the code and then build

WindowHelper.EnableBlur(this);

Can u tell me how to do that??

Explained in the wiki

@DiegoMagdaleno
Copy link

Maybe quicklook should migrate to the new Mika material instead of blur?

@fytuf
Copy link

fytuf commented Jul 30, 2021

Interesting, this bug only seems to happen in the NEW Explorer. It works perfectly fine on Files UWP, the desktop, and the old ribbon explorer.

@xupefei
Copy link
Member

xupefei commented Jul 31, 2021

Added a workaround to Nightly, please use the Nightly version plus this config, until MS fixed this issue.

@prakharb5
Copy link
Author

I installed the nightly build and disable transparency via config, and its working normally now! 🎉

But it has these ugly white pixels in the corners, but I guess this is an issue on MS' side, since I have seen this with other apps too.

image

@xupefei
Copy link
Member

xupefei commented Aug 2, 2021

The white border pixels might comes from the window border. I'll look into it later.

@Schlave
Copy link

Schlave commented Aug 5, 2021

White artefacts seems to be fixed with nightly build + transparency disabled + latest Windows 11 preview build (Build 22000.120) just released today. Just tried it.
Screenshot 2021-08-06 031934

They mentioned it in the fixes: "We've done some work to remove the unexpected white artifacts in the corners of windows when using dark mode."

@omorefe
Copy link

omorefe commented Aug 11, 2021

also not working for me, same problems

@xupefei
Copy link
Member

xupefei commented Aug 11, 2021

also not working for me, same problems

Have you check this comment above?

Added a workaround to Nightly, please use the Nightly version plus this config, until MS fixed this issue.

@OpenWaygate
Copy link

I have installed the nightly version on 22000.132 but not modify the transparency settings, the preview window appears right after I start quicklook, but several hours later I press space nothing hapens, I have to restart quicklook.

@xupefei
Copy link
Member

xupefei commented Aug 16, 2021

I have installed the nightly version on 22000.132 but not modify the transparency settings, the preview window appears right after I start quicklook, but several hours later I press space nothing hapens, I have to restart quicklook.

You have to modify the transparency flag in the nightly version. Of course you'll have a problem if you don't do that.

@mwidmann
Copy link

mwidmann commented Aug 26, 2021

I upgraded to the nightly version and disabled transparency. It works nicely now. The only thing is that the keyboard navigation between files doesn't work anymore. If I'm in a folder with more than one file, the old version jumped to the next file if ich hit the down key on the keyboard. This doesn't work anymore.

@NFLS-1963
Copy link

Same.

@WhiteNervosa
Copy link

I felt like an idiot looking on Appveyor for awhile but it seems the nightly build expired for being a month old.

Can it be bumped or am I missing it, elsewhere?

@Void48
Copy link

Void48 commented Sep 6, 2021

Nightly builds expired :/ @xupefei

@xupefei
Copy link
Member

xupefei commented Sep 7, 2021

@WhiteNervosa @Void48
New build: https://ci.appveyor.com/project/xupefei/quicklook/build/artifacts

I'll release a new version this weekend.

@NFLSCode
Copy link

NFLSCode commented Sep 7, 2021

@xupefei thanks.

@Zbynius
Copy link

Zbynius commented Sep 14, 2021

@xupefei Which weekend is it about?

@Zbynius
Copy link

Zbynius commented Sep 14, 2021

Font plugin don't work in Windows 11 (64 bit Home) in nightly version QuickLook QuickLook-3.6.11-24-g69d6aa0.
Crashing on TTF and OTF font files.

@xaryangupta
Copy link

can you make it possible to subscribe to nightly builds within the app (like ShareX)? or on ms store thru signup emails(like Xodo PDF and Files by Yair)? or a separate Quicklook nightly on the store?(like Windows Terminal/myTube)

@xaryangupta
Copy link

Also quicklook doesnt seem to work with Everything 1.5a (voidtools)

@rabelux
Copy link
Member

rabelux commented Sep 15, 2021

can you make it possible to subscribe to nightly builds within the app (like ShareX)? or on ms store thru signup emails(like Xodo PDF and Files by Yair)? or a separate Quicklook nightly on the store?(like Windows Terminal/myTube)

Just subscribe/watch this project on github and you'll get emails on commits which cause new nightly builds.

@xupefei
Copy link
Member

xupefei commented Sep 15, 2021

@xupefei Which weekend is it about?

Maybe this weekend... I'm now moving, so I don't know when I can unpack & setup my developing rig.

@xaryangupta
Copy link

No updates for quite some time...

@Zbynius
Copy link

Zbynius commented Sep 17, 2021

@xZayn Be patient! The developer is already working on it. It's a matter of a few days. The temporary solution (nightly version) works OK.

@xupefei
Copy link
Member

xupefei commented Sep 20, 2021

Fixed in Version 3.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests