Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macromodel hessian weight assignment #70

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

v3op01
Copy link

@v3op01 v3op01 commented Oct 24, 2019

Supposedly fixing the problem discussed.

@ericchansen
Copy link

Can you add some docs to sch_util.py before approval? What The function names and variables don't clearly express what they do. I think some docstrings should be required.

@v3op01
Copy link
Author

v3op01 commented Oct 24, 2019

Added descriptions

@v3op01 v3op01 closed this Oct 24, 2019
@v3op01 v3op01 reopened this Oct 24, 2019
@v3op01
Copy link
Author

v3op01 commented Mar 13, 2020

With the most recent issue fixed in compare.py

@ericchansen
Copy link

referencing issue #73

@ericchansen
Copy link

ericchansen commented Mar 13, 2020

Can anyone run some tests on this code? If it passes some tests, I'd say good enough.

@mmfarrugia
Copy link

Hi @ericchansen and @v3op01 ,

I know it's been quite some time, but do you happen to recall what this was? If it was in Kevin's local version of q2mm on the group afs then it has been incorporated, but otherwise it would be good to know what this might have been since the PR was never approved and merged.

Thanks!

Mikaela

@ericchansen
Copy link

I think I have to defer to @v3op01 as the expert on this PR. I can't recall the original issue or intent of these code changes.

I more-or-less gave this OR a thumbs up 4 years ago, but take my input with a grain of salt. I never ran any tests with this branch myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants