-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Nested decomp #389
[WIP] Nested decomp #389
Conversation
Update changes in master.
Codecov Report
@@ Coverage Diff @@
## master #389 +/- ##
==========================================
+ Coverage 64.7% 66.25% +1.55%
==========================================
Files 442 487 +45
Lines 61511 63170 +1659
==========================================
+ Hits 39799 41853 +2054
+ Misses 21712 21317 -395
Continue to review full report at Codecov.
|
@jsiirola I seem to recall discussing with you that this example would sit better as a contrib package. Do you recall? |
Not sure if you discussed this with John or not, but I agree. I asked for this to be moved from core Pyomo to examples, however, this was before contrib really existed. I think we should add an examples directory to contrib, and put this there. We have asked Cristiana to move this already (and she did), so let's make sure we know where we want it before asking again (or move it ourselves). |
Do we really want a pyomo.contrib.examples sub-package? I hadn't thought of that, and I'm inclined to use a simpler directory structure. |
Everything should be made as simple as possible, but no simpler. |
This has been added to the Archived design discussions wiki; will close for now. |
Fixes # .
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: