Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs of the documentation of Pyomo.DoE #3070

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

jialuw96
Copy link
Contributor

Summary/Motivation:

This fixes the problem that in the documentation, step 4: enumeration and step 5: gradient-based optimization, show the same code.

Changes proposed in this PR:

  • in doe.rst step 4 enumeration, change the code included in this part to reactor_grid_search.py
  • in doe.rst step 5 optimization, change the code included in this part to reactor_optimize_doe.py

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@adowling2
Copy link
Member

@blnicho @jsiirola @mrmundt Shall fix to the documentation.

@jsiirola
Copy link
Member

The failing Jenkins tests are unrelated to this PR. This is safe to merge

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (809a58a) 88.09% compared to head (5dc5cd5) 88.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3070   +/-   ##
=======================================
  Coverage   88.09%   88.09%           
=======================================
  Files         774      774           
  Lines       91537    91537           
=======================================
+ Hits        80642    80643    +1     
+ Misses      10895    10894    -1     
Flag Coverage Δ
linux 85.45% <ø> (ø)
osx 75.47% <ø> (ø)
other 85.63% <ø> (ø)
win 82.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsiirola jsiirola merged commit 3bab26c into Pyomo:main Dec 14, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants