Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 Support #3050

Merged
merged 29 commits into from
Nov 28, 2023
Merged

Add Python 3.12 Support #3050

merged 29 commits into from
Nov 28, 2023

Conversation

mrmundt
Copy link
Contributor

@mrmundt mrmundt commented Nov 27, 2023

Fixes #3014

Summary/Motivation:

This updates the Pyomo build harness, and includes fixed so that tests pass on Python 3.12

Changes proposed in this PR:

  • Update slice detection logic to support hashable slice objects (added in Python 3.12)
  • Update Trustregion tests (tolerance and API)
  • Update a magic number used for recursion testing

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@blnicho
Copy link
Member

blnicho commented Nov 27, 2023

Missed reference to supported Python versions in:
https://github.com/Pyomo/pyomo/blob/main/doc/OnlineDocs/installation.rst

This is a non-functional change so I'm fine with waiting for the currently running tests to pass and then making this minor change and merging.

@mrmundt
Copy link
Contributor Author

mrmundt commented Nov 27, 2023

Missed reference to supported Python versions in: https://github.com/Pyomo/pyomo/blob/main/doc/OnlineDocs/installation.rst

This is a non-functional change so I'm fine with waiting for the currently running tests to pass and then making this minor change and merging.

I have it queued up to push when these tests complete.

@mrmundt
Copy link
Contributor Author

mrmundt commented Nov 27, 2023

Missed reference to supported Python versions in: https://github.com/Pyomo/pyomo/blob/main/doc/OnlineDocs/installation.rst
This is a non-functional change so I'm fine with waiting for the currently running tests to pass and then making this minor change and merging.

I have it queued up to push when these tests complete.

Jk, @jsiirola was impatient ;)

@jsiirola jsiirola merged commit 7c18cdd into Pyomo:main Nov 28, 2023
@mrmundt mrmundt deleted the add-python-312 branch March 11, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Wheel Building Action
3 participants