Add a single-file example

.circleci/config.yml

@@ -40,9 +40,9 @@ jobs:
       # Download and cache dependencies
       - restore_cache:
           keys:
-            - v3-dependencies-{{ checksum "Pipfile.lock" }}
+            - v4-dependencies-{{ checksum "Pipfile.lock" }}
             # fallback to using the latest cache if no exact match is found
-            - v3-dependencies-
+            - v4-dependencies-
 
       - run:
           name: install dependencies
@@ -54,13 +54,19 @@ jobs:
       - save_cache:
           paths:
             - ./.venv
-          key: v3-dependencies-{{ checksum "Pipfile.lock" }}
+          key: v4-dependencies-{{ checksum "Pipfile.lock" }}
 
       - run:
           name: run tests
           command: |
             make tests
 
+      - run:
+          name: run tests for the singlefile example
+          command: |
+            cd examples/singlefile
+            pipenv run python -m unittest app.py
+
   release:
     <<: *defaults
 
@@ -69,9 +75,9 @@ jobs:
 
       - restore_cache:
           keys:
-            - v3-dependencies-{{ checksum "Pipfile.lock" }}
+            - v4-dependencies-{{ checksum "Pipfile.lock" }}
             # fallback to using the latest cache if no exact match is found
-            - v3-dependencies-
+            - v4-dependencies-
 
       - run:
           name: install dependencies
@@ -84,7 +90,7 @@ jobs:
       - save_cache:
           paths:
             - ./.venv
-          key: v3-dependencies-{{ checksum "Pipfile.lock" }}
+          key: v4-dependencies-{{ checksum "Pipfile.lock" }}
 
       - run:
           name: verify git tag vs. version

Pipfile

@@ -32,6 +32,7 @@ pytest = "*"
 pytest-cov = "*"
 pytest-randomly = "*"
 twine = "*"
+webtest = "*"
 
 [packages]
 "pyramid-openapi3" = {editable = true, path = "."}

examples/singlefile/app.py

@@ -0,0 +1,150 @@
+"""A single-file demo of pyramid_openapi3.
+
+Usage:
+* git clone https://github.com/niteoweb/pyramid_openapi3.git
+* cd pyramid_openapi3/examples/singlefile
+* virtualenv -p python3.7 .
+* source bin/activate
+* pip install pyramid_openapi3
+* python app.py
+"""
+
+from pyramid.config import Configurator
+from pyramid.httpexceptions import HTTPForbidden
+from pyramid.view import view_config
+from wsgiref.simple_server import make_server
+
+import tempfile
+import unittest
+
+# This is usually in a separate openapi.yaml file, but for the sake of the
+# example we want everything in a single file. Other examples have it nicely
+# separated.
+OPENAPI_DOCUMENT = b"""
+    openapi: "3.0.0"
+    info:
+      version: "1.0.0"
+      title: Hello API
+    paths:
+      /hello:
+        get:
+          parameters:
+            - name: name
+              in: query
+              required: true
+              schema:
+                type: string
+                minLength: 3
+          responses:
+            200:
+              description: Say hello
+"""
+
+
+@view_config(route_name="hello", renderer="json", request_method="GET", openapi=True)
+def hello(request):
+    """Say hello."""
+    if request.openapi_validated.parameters["query"]["name"] == "admin":
+        raise HTTPForbidden()
+    return {"hello": request.openapi_validated.parameters["query"]["name"]}
+
+
+def app(spec):
+    """Prepare a Pyramid app."""
+    with Configurator() as config:
+        config.include("pyramid_openapi3")
+        config.pyramid_openapi3_spec(spec)
+        config.pyramid_openapi3_add_explorer()
+        config.add_route("hello", "/hello")
+        config.scan(".")
+        return config.make_wsgi_app()
+
+
+if __name__ == "__main__":
+    """If app.py is called directly, start up the app."""
+    with tempfile.NamedTemporaryFile() as document:
+        document.write(OPENAPI_DOCUMENT)
+        document.seek(0)
+
+        print("visit api explorer at http://0.0.0.0:6543/docs/")  # noqa: T001
+        server = make_server("0.0.0.0", 6543, app(document.name))
+        server.serve_forever()
+
+
+#######################################
+#           ---- Tests ----           #
+# A couple of functional tests to     #
+# showcase pyramid_openapi3 features. #
+# Usage: python -m unittest app.py    #
+#######################################
+
+from openapi_core.schema.parameters.exceptions import InvalidParameterValue  # noqa
+from openapi_core.schema.parameters.exceptions import MissingRequiredParameter  # noqa
+from openapi_core.schema.responses.exceptions import InvalidResponse  # noqa
+
+
+class FunctionalTests(unittest.TestCase):
+    """A suite of tests that make actual requests to a running app."""
+
+    def setUp(self):
+        """Start up the app so that tests can send requests to it."""
+        from webtest import TestApp
+
+        with tempfile.NamedTemporaryFile() as document:
+            document.write(OPENAPI_DOCUMENT)
+            document.seek(0)
+
+            self.testapp = TestApp(app(document.name))
+
+    def test_nothing_on_root(self):
+        """We have not configured our app to serve anything on root."""
+        res = self.testapp.get("/", status=404)
+        self.assertIn("404 Not Found", res.text)
+
+    def test_api_explorer_on_docs(self):
+        """Swagger's API Explorer should be served on /docs/."""
+        res = self.testapp.get("/docs/", status=200)
+        self.assertIn("<title>Swagger UI</title>", res.text)
+
+    def test_hello(self):
+        """Say hello."""
+        res = self.testapp.get("/hello?name=john", status=200)
+        self.assertIn('{"hello": "john"}', res.text)
+
+    def test_undefined_response(self):
+        """Saying hello to admin should fail with 403 Forbidden.
+
+        But because we have not defined how a 403 response should look in
+        OPENAPI_DOCUMENT, we instead get a InvalidResponse exception.
+
+        This is to prevent us from forgetting to define all possible responses
+        in our opeanapi document.
+        """
+        try:
+            self.testapp.get("/hello?name=admin", status=200)
+        except InvalidResponse as exc:
+            self.assertEqual(str(exc), "Unknown response http status: 403")
+
+    def test_name_missing(self):
+        """Our view code does not even get called is request is not per-spec.
+
+        We don't have to write (and test!) any validation code in our view!
+        """
+        try:
+            self.testapp.get("/hello", status=200)
+        except MissingRequiredParameter as exc:
+            self.assertEqual(str(exc), "Missing required parameter: name")
+
+    def test_name_too_short(self):
+        """A name that is too short is picked up by openapi-core validation.
+
+        We don't have to write (and test!) any validation code in our view!
+        """
+        try:
+            self.testapp.get("/hello?name=yo", status=200)
+        except InvalidParameterValue as exc:
+            self.assertEqual(
+                str(exc),
+                "Invalid parameter value for `name`: Value is shorter (2) "
+                "than the minimum length of 3",
+            )

pyramid_openapi3/__init__.py

@@ -59,6 +59,7 @@ def wrapper_view(context, request):
                     )
                 else:
                     # Do the view
+                    request.openapi_validated.raise_for_errors()
                     response = view(context, request)
 
             except HTTPException as exc:
@@ -151,7 +152,6 @@ def spec_view(request):
 
         config.add_route(route_name, route)
         config.add_view(route_name=route_name, view=spec_view)
-        config.add_view(route_name=route_name, view=spec_view)
 
         custom_formatters = config.registry.settings.get("pyramid_openapi3_formatters")
 

tests/test_views.py

@@ -17,18 +17,18 @@
 import pytest
 import tempfile
 
-MINIMAL_DOCUMENT = (
-    b'openapi: "3.0.0"\n'
-    b"info:\n"
-    b'  version: "1.0.0"\n'
-    b"  title: Foo API\n"
-    b"paths:\n"
-    b"  /foo:\n"
-    b"    get:\n"
-    b"      responses:\n"
-    b"        200:\n"
-    b"          description: A foo\n"
-)
+MINIMAL_DOCUMENT = b"""
+    openapi: "3.0.0"
+    info:
+      version: "1.0.0"
+      title: Foo API
+    paths:
+      /foo:
+        get:
+          responses:
+            200:
+              description: A foo
+"""
 
 
 def test_add_spec_view():