Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed Attachment Metadata Being Set Incorrectly In Interaction Responses #2679

Merged
merged 6 commits into from
Dec 28, 2024
Merged

fix: Fixed Attachment Metadata Being Set Incorrectly In Interaction Responses #2679

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
984cbac
fix: Fixed Attachment Metadata Being Set Incorrectly In Interaction R…
Icebluewolf Dec 27, 2024
4fcb515
Merge branch 'master' into interaction_attachment_metadata
Icebluewolf Dec 27, 2024
fb09d53
style(pre-commit): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 27, 2024
75b7ef0
fix: Ensure Payload Data Exists
Icebluewolf Dec 28, 2024
21f43af
Merge branch 'master' into interaction_attachment_metadata
Icebluewolf Dec 28, 2024
88503b7
chore: use inline if
Dorukyum Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ These changes are available on the `master` branch, but have not yet been releas
- Fixed an error when responding non-ephemerally with a `Paginator` to an ephemerally
deferred interaction.
([#2661](https://github.com/Pycord-Development/pycord/pull/2661))
- Fixed attachment metadata being set incorrectly in interaction responses causing the
metadata to be ignored by Discord.
([#2679](https://github.com/Pycord-Development/pycord/pull/2679))

### Changed

Expand Down
2 changes: 1 addition & 1 deletion discord/webhook/async_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ def create_interaction_response(
"content_type": "application/octet-stream",
}
)
payload["attachments"] = attachments
payload["data"]["attachments"] = attachments
form[0]["value"] = utils._to_json(payload)

route = Route(
Expand Down
Loading