Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Fix duplicate bridge cmds in default help cmd #2656

Merged

Conversation

Paillat-dev
Copy link
Contributor

@Paillat-dev Paillat-dev commented Nov 27, 2024

Summary

Fixes: #2306
Closes: #2415
Alternative to: #2415 (stale imo)
If you prefer waiting for #2415 I don't mind, just made a quick fix here because that pr seemed dead.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • [~] I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Lulalaby
Lulalaby previously approved these changes Nov 27, 2024
@Lulalaby Lulalaby enabled auto-merge (squash) November 27, 2024 14:03
@Paillat-dev
Copy link
Contributor Author

Please don't merge this yet I thought of something I want to test first.

@Paillat-dev
Copy link
Contributor Author

Ok I fixed a small issue there.

@Paillat-dev Paillat-dev requested a review from Lulalaby December 9, 2024 10:44
@Paillat-dev
Copy link
Contributor Author

In any case, the code for this help command is reeeally messed up ngl

Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like me fr

@Dorukyum Dorukyum requested review from Dorukyum and removed request for plun1331 January 14, 2025 15:21
plun1331
plun1331 previously approved these changes Jan 28, 2025
Lulalaby
Lulalaby previously approved these changes Jan 28, 2025
Signed-off-by: Lala Sabathil <lala@pycord.dev>
@Lulalaby
Copy link
Member

@plun1331 new review pls

@Lulalaby Lulalaby merged commit aa13d82 into Pycord-Development:master Jan 28, 2025
25 checks passed
@Paillat-dev Paillat-dev deleted the fix-help-duplicate-cmds branch January 29, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command duplication in cog help
4 participants