Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: '_io.BytesIO' object has no attribute 'name' in paginator #1869

Merged
merged 10 commits into from
Jan 11, 2023
Merged

fix: '_io.BytesIO' object has no attribute 'name' in paginator #1869

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
17c937e
Update pagination.py
yoggys Jan 11, 2023
2efc707
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 11, 2023
3f7a668
Update discord/ext/pages/pagination.py
yoggys Jan 11, 2023
1a6616b
Update discord/ext/pages/pagination.py
yoggys Jan 11, 2023
4ec5992
update changelog
yoggys Jan 11, 2023
c642bc9
move to correct section
yoggys Jan 11, 2023
3bbe0f6
fix: add __future__.annotations import
BobDotCom Jan 11, 2023
a5a8adb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 11, 2023
fa70b51
Update CHANGELOG.md
BobDotCom Jan 11, 2023
827fbd3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion discord/ext/pages/pagination.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
DEALINGS IN THE SOFTWARE.
"""
from io import BufferedReader
from typing import Dict, List, Optional, Union

import discord
Expand Down Expand Up @@ -166,10 +167,12 @@ async def callback(self, interaction: Optional[discord.Interaction] = None):
"""

def update_files(self) -> Optional[List[discord.File]]:
"""Updates the files associated with the page by re-uploading them.
"""If possible, it updates the files associated with the page by re-uploading them.
Typically used when the page is changed.
"""
for file in self._files:
if not isinstance(file.fp, BufferedReader):
continue
with open(file.fp.name, "rb") as fp: # type: ignore
self._files[self._files.index(file)] = discord.File(
fp, # type: ignore
Expand Down