[ext.pages] Fixes and enhancements for PageGroup
handling
#1350
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR does the following:
PageGroup
objects were not respecting theirdefault_button_row
parameter due to a missing parameter inPaginatorMenu
's callback toPaginator.update
.Paginator.update
did not allow updating thepages
parameter with a new list ofPageGroup
objectsPaginatorMenu
's callback toPaginator.update
(timeout
,trigger_on_display
)PageGroup
object to show when the paginator is sent (controlled by a newdefault
parameter on thePageGroup
object)Checklist
type: ignore
comments were used, a comment is also left explaining why