Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ext.pages] Fixes and enhancements for PageGroup handling #1350

Merged
merged 5 commits into from
May 13, 2022
Merged

[ext.pages] Fixes and enhancements for PageGroup handling #1350

merged 5 commits into from
May 13, 2022

Conversation

krittick
Copy link
Contributor

Summary

This PR does the following:

  1. Fixes an issue where PageGroup objects were not respecting their default_button_row parameter due to a missing parameter in PaginatorMenu's callback to Paginator.update.
  2. Fixes an issue where Paginator.update did not allow updating the pages parameter with a new list of PageGroup objects
  3. Fixes other missing parameters in PaginatorMenu's callback to Paginator.update (timeout, trigger_on_display)
  4. Adds support for specifying a default PageGroup object to show when the paginator is sent (controlled by a new default parameter on the PageGroup object)

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

krittick added 2 commits May 13, 2022 13:52
…ginator.update`

Add `default` parameter to `PageGroup` which controls the initial `PageGroup`'s list of pages to display.
add logic to allow replacing PageGroups in `Paginator.update`
add `Paginator.get_page_group_content` method to convert `PageGroup` pages to `Page` objects when initialized / updated.
@krittick krittick added bug Something isn't working priority: high High Priority bypass-review Bypasses reviews for urgent pull requests involving critical code or documentation fixes. feature Implements a feature Merge with squash ext.pages Relating to ext.pages labels May 13, 2022
@krittick krittick added this to the v2.0 milestone May 13, 2022
@krittick krittick self-assigned this May 13, 2022
@krittick krittick merged commit 028dd27 into Pycord-Development:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bypass-review Bypasses reviews for urgent pull requests involving critical code or documentation fixes. ext.pages Relating to ext.pages feature Implements a feature priority: high High Priority
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant