Fix/partial run

[srijanpatel]

This pull request includes significant updates to the Header and RunModal components in the frontend, with a focus on state management improvements and code simplification. The most important changes include the introduction of new state variables for managing the selected test input and the run modal's open state, as well as the refactoring of related components and hooks to use these new state variables.

State Management Improvements:

• Added selectedTestInputId and isRunModalOpen state variables to the flowSlice to manage the selected test input and the run modal's open state (frontend/src/store/flowSlice.ts) [1] [2].

Component Updates:

• Updated Header component to use the new selectedTestInputId and isRunModalOpen state variables, replacing local state variables and simplifying modal handling (frontend/src/components/Header.tsx) [1] [2] [3] [4] [5] [6].
• Refactored RunModal component to remove selectedRow state and use selectedTestInputId from the global state instead (frontend/src/components/modals/RunModal.tsx) [1] [2] [3] [4] [5] [6] [7] [8] [9].

Hook Updates:

• Modified usePartialRun hook to leverage the new selectedTestInputId state and handle the case where no initial inputs are provided by opening the run modal (frontend/src/hooks/usePartialRun.ts) [1] [2] [3] [4].

These changes collectively enhance the maintainability and readability of the codebase by centralizing state management and reducing redundancy.

---

Important

Improve state management in Header and RunModal by introducing global state variables for selected test input and run modal state.

• State Management:
  • Add selectedTestInputId and isRunModalOpen to flowSlice for managing selected test input and run modal state.
• Component Updates:
  • Update Header to use selectedTestInputId and isRunModalOpen, replacing local state variables.
  • Refactor RunModal to remove selectedRow state, using selectedTestInputId from global state.
• Hook Updates:
  • Modify usePartialRun to use selectedTestInputId and handle no initial inputs by opening run modal.
• Misc:
  • Add setSelectedTestInputId and setRunModalOpen actions in flowSlice.

^{This description was created by for 748dbe2. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 748dbe2 in 1 minute and 45 seconds

More details

• Looked at 439 lines of code in 5 files
• Skipped 0 files when reviewing.
• Skipped posting 10 drafted comments based on config settings.

1. frontend/src/components/Header.tsx:87

• Draft comment:
  Good refactor: using global state (setRunModalOpen) to control the modal improves consistency.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

2. frontend/src/components/modals/RunModal.tsx:77

• Draft comment:
  Transition from local selectedRow state to global selectedTestInputId is well-managed; ensure the useEffect dependencies include dispatch.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

3. frontend/src/hooks/usePartialRun.ts:45

• Draft comment:
  The fallback for initialInputs using the selected test input is clear and handles the case when no inputs are provided by opening the modal.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

4. frontend/src/store/flowSlice.ts:757

• Draft comment:
  New reducers (setSelectedTestInputId and setRunModalOpen) are added properly and integrated within the state. This centralizes state management for UI modals.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

5. frontend/src/types/api_types/flowStateSchema.ts:21

• Draft comment:
  The FlowState type now includes selectedTestInputId and isRunModalOpen, ensuring type safety for global state.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

6. frontend/src/components/Header.tsx:49

• Draft comment:
  Remove unused local state 'isDebugModalOpen' since global 'isRunModalOpen' (from the store) is now used. This will simplify the component.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

7. frontend/src/components/modals/RunModal.tsx:513

• Draft comment:
  Consider extracting the repeated condition checking for unsaved editor content into a constant to improve readability.
• Reason this comment was not posted:
  Confidence changes required: 50% <= threshold 50%
  None

8. frontend/src/hooks/usePartialRun.ts:46

• Draft comment:
  The logic for deriving 'effectiveInitialInputs' from selectedTestInputId and testInputs looks good. Consider adding a brief comment to explain this fallback for clarity.
• Reason this comment was not posted:
  Confidence changes required: 30% <= threshold 50%
  None

9. frontend/src/store/flowSlice.ts:650

• Draft comment:
  When deleting a test input, consider also resetting 'selectedTestInputId' if it matches the deleted input, to keep the global state consistent.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

10. frontend/src/types/api_types/flowStateSchema.ts:21

• Draft comment:
  FlowState schema now includes selectedTestInputId and isRunModalOpen. The changes look consistent with the new global state management. Make sure all components using these state variables have been updated accordingly.
• Reason this comment was not posted:
  Confidence changes required: 20% <= threshold 50%
  None

Workflow ID: wflow_iK0updgwkauU0akw

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.