-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: add pre-commit yaml #162
Open
finozzifa
wants to merge
15
commits into
PyPSA:master
Choose a base branch
from
open-energy-transition:add_pre_commit
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkstrp
reviewed
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @finozzifa !
I added the repo to the pre-commit ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes # (if applicable).
Changes proposed in this Pull Request
The contribution proposes:
-) the addition of .pre-commit-config.yaml
-) adding the license mentions in the necessary files
-) fixing typos as suggested by ruff
Testing
As a test, I have re-executed the snakemake rule compile_cost_assumptions. The newly generated files are identical to previous ones, apart from what detailed below.
The changes are caused by the following typo corrections:
costs_2020.csv
costs_2025.csv
costs_2030.csv
costs_2035.csv
costs_2040.csv
costs_2045.csv
costs_2050.csv
Checklist
doc
.environment.yaml
(if applicable).doc/release_notes.rst
of the upcoming release is included.