Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust AC bus to low voltage #948

Merged
merged 3 commits into from
Feb 26, 2024
Merged

adjust AC bus to low voltage #948

merged 3 commits into from
Feb 26, 2024

Conversation

lisazeyen
Copy link
Contributor

@lisazeyen lisazeyen commented Feb 23, 2024 •
edited
Loading

Closes # (if applicable).
Add existing heat pumps to low voltage if low voltage grid is modelled.

Changes proposed in this Pull Request

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

@lisazeyen lisazeyen requested a review from nworbmot February 23, 2024 15:52
@lisazeyen lisazeyen assigned p-glaum and unassigned p-glaum Feb 23, 2024
@lisazeyen lisazeyen requested a review from p-glaum February 23, 2024 15:53
p-glaum
p-glaum approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@p-glaum p-glaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lisazeyen lisazeyen merged commit a5f7b11 into master Feb 26, 2024
6 checks passed
@lindnemi lindnemi mentioned this pull request Apr 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-glaum p-glaum p-glaum approved these changes

@nworbmot nworbmot Awaiting requested review from nworbmot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lisazeyen @p-glaum