create a bus for every unique coordinate, not only substations #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martacki
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Nice, also did some plots at elec.nc, and compared to before, now every (visible) node has a Voronoi region.
Sometimes (in case of the whole EUR network without UA/MD, it happens for 6 cases), locations that are intended to have the same geo-coordinates (but have a very small deviation in 4th decimal digit or so) get two separate regions. But this is resolved after simplify_network (after mapping the network to one voltage level where these nodes are aggregated). So not really worth to add some rounding accuracy, I'd say. After simplify_network, this case does not appear anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #699