Check WDPA url also a month forward #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ekatef FYI :) |
|
I believe the windows failure is due to an issue with progressbar. There was a recently released bugfix which is not yet in our cached environment.... It should be fixed next year by rerunning the windows CI |
martacki
reviewed
Dec 22, 2023
| next_monthyear = (datetime.now() + timedelta(30)).strftime("%b%Y") | ||
|
|
||
| # Test prioritised: current month -> previous -> next | ||
| for bYYYY in [current_monthyear, prev_monthyear, next_monthyear]: |
There was a problem hiding this comment.
on the same note, if config["enable"]["retrieve"] is false, then bYYYY doesnt exist in add_electricity.smk maybe we can add the same code there ?
There was a problem hiding this comment.
Good point!
Generally, the downloaded file should drop the month in the filename. This is because otherwise, a new month would trigger the whole workflow to re-execute and invalidate all existing (intermediate) results.
I will prepare a separate pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #807
Changes proposed in this Pull Request
Checklist
envs/environment.yaml.config.default.yaml.doc/configtables/*.csv.doc/release_notes.rstis added.