Update cluster_network to avoid adding deleted links in clustered net… #678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes # (if applicable).
Changes proposed in this Pull Request
While testing PyPSA-Earth, I found a bug in the links clustering detailed in pypsa-meets-earth/pypsa-earth#735.
In particular, in the specific case, I clustered the LT network into 5 nodes and after the clustering, the unique link was connected to the same bus, so it was dropped and no links where available.
However, in performing the calculation to add the underground water, the old link was added with nan values because no dropna() was added.
This PR fixes that.
I don't think this needs a release_note, though, let me know
Checklist
envs/environment.yaml
.config.default.yaml
.doc/configtables/*.csv
.doc/release_notes.rst
is added.