Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNMY] Address pandas deprecation of date_parser for pandas.read_csv #648

Merged
merged 4 commits into from
Jan 2, 2024

Conversation

euronion
Copy link
Contributor

pandas=2.0 deprecates date_parser for read_csv. Fixing this issue here by providing a time_format without timezone info parsing instead.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • [n/a] Changes in configuration options are added in all of config.default.yaml.
  • [n/a] Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

@fneum
Copy link
Member

fneum commented Apr 24, 2023

Is it a good idea to increase the minimum pandas requirement to version 2.0 already? Or should we keep this PR open for a while?

@euronion
Copy link
Contributor Author

I don't see an immediate need to merge. Maybe we can have a release soon and merge afterwards?

@fneum fneum changed the title Address pandas deprecation of date_parser for pandas.read_csv [DNMY] Address pandas deprecation of date_parser for pandas.read_csv Apr 30, 2023
@fneum fneum enabled auto-merge December 29, 2023 10:36
@fneum fneum disabled auto-merge January 2, 2024 08:35
@fneum fneum merged commit ceddecd into master Jan 2, 2024
2 of 3 checks passed
@fneum fneum deleted the misc/deprecations branch January 2, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants