Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configs in one folder #640

Merged
merged 14 commits into from
Apr 21, 2023
Merged

Configs in one folder #640

merged 14 commits into from
Apr 21, 2023

Conversation

virio-andreyana
Copy link
Collaborator

Closes #632

Changes proposed in this Pull Request

  • Move all config files (including test config files) to a config folder name "configs"
  • changes the Snakemake file, so that the config.yaml would be located inside the configs folder
  • since each results folder already contain the config.yaml file, syncignore-receive is updated to ignore the configs folder

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

Note: this also includes the test config files. Update must be made for the tutorial
insert the new path for config for the copying process, solve the error in rule copy_config
@virio-andreyana
Copy link
Collaborator Author

Note that all of the CI don't work because the directory of the file 'test/config.electricity.yaml' have been moved.

@fneum
Copy link
Member

fneum commented Apr 12, 2023

Note that all of the CI don't work because the directory of the file 'test/config.electricity.yaml' have been moved.

Could you also adapt the references to config files in CI and documentation? Then CI should work.

@fneum
Copy link
Member

fneum commented Apr 21, 2023

Some items in the documentation will also be affected by this moving of config files.

@fneum fneum merged commit 2b069e3 into master Apr 21, 2023
@fneum fneum deleted the configs-in-one-folder branch April 21, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move all config files to configs folder
3 participants