Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solve_network: move extra_functionality to args #445

Merged
merged 4 commits into from
Dec 8, 2022

Conversation

martacki
Copy link
Member

Closes # (if applicable).

Changes proposed in this Pull Request

Currently if solve_network is used outside pypsa-eur (for example via import), no additional extra_functionality can be passed as kwarg. If it is removed from the function and only passed as kwarg instead, this problem is resolved.

associated error: TypeError: pypsa.linopf.network_lopf() got multiple values for keyword argument 'extra_functionality'

Thoughts?

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes.

@martacki martacki requested a review from fneum December 7, 2022 17:11
@fneum fneum merged commit cf56810 into master Dec 8, 2022
@fneum fneum deleted the extra_functionality_to_args branch December 8, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants