-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable scneario management for different configs #413
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3804acf
to
a95ee64
Compare
a95ee64
to
9d8ecfb
Compare
9d8ecfb
to
71ba743
Compare
p-glaum
reviewed
Sep 8, 2022
Co-authored-by: Philipp Glaum <95913147+p-glaum@users.noreply.github.com>
@fneum any objection to merge this? |
fneum
requested changes
Sep 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Especially, since it keeps paths as they were if no run-name is specified!
Just a few minor comments:
Could you document new run
options also at
https://github.com/PyPSA/pypsa-eur/blob/master/doc/configtables/toplevel.csv
Co-authored-by: Fabian Neumann <fabian.neumann@outlook.de>
Co-authored-by: Fabian Neumann <fabian.neumann@outlook.de>
d2a1cf4
to
b694337
Compare
fneum
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the release notes:
The software now supports running the workflow with different settings within the same directory. A new config section
run
was created that specifies under which scenarioname
the created resources, networks and results should be stored. Ifname
is not specified, the workflow uses the default paths. The entrydedicated_cutout
specifies whether the run should use cutouts from the default root directory and use run-specific cutouts.@fneum @p-glaum any suggestion on how to rename
dedicated_cutouts
? No so happy with this key...Note this is a non-breaking change.
Checklist
doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes.