-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace bioenergy and MSW stores with generators #1373
Conversation
Validator ReportI am the Validator. Download all artifacts here. General Files comparison
NRMSE: Normalized (combined-min-max) Root Mean Square Error Model Metrics Comparing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed changes make sense, but some adjustments are necessary:
- The new minimum version of PyPSA should be specified in the
environment.yaml
since this PR uses a new feature. - A release note should be added, especially since there are some hidden changes (i.e. forced use of MSW, changed carrier name for biomass transport)
- Do you actually still need the operational limit GlobalConstraint for MSW? If you want all MSW to be used, you could also just set
e_sum_min = e_sum_max
, right?
Thanks for the review @fneum!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation! If 0.31 is already specified, it's all good!
Closes # (if applicable).
Changes proposed in this Pull Request
As the Generator component is extended in PyPSA/PyPSA#1047, it can replace the Store components for bioenergy and municipal solid waste. The extension of the Generator allows for a more efficient representation of finite resources, such as biomass, by eliminating the need for storage consistency constraints. Additionally, the desired model behavior to enforce the use of unsustainable bioenergy types and municipal solid waste is addressed through the new e_sum_min attribute.
Checklist
envs/environment.yaml
.config/config.default.yaml
.doc/configtables/*.csv
.doc/data_sources.rst
.doc/release_notes.rst
is added.