Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify script aggregates Corsica to Italy #152

Closed
martacki opened this issue Apr 7, 2020 · 9 comments
Closed

simplify script aggregates Corsica to Italy #152

martacki opened this issue Apr 7, 2020 · 9 comments

Comments

@martacki
Copy link
Member

martacki commented Apr 7, 2020

full resolution includes one bus for corsica (bus "2306"), that, when simplifying, gets aggregated to Italy "Festland" (bus "2343") which we do not want to happen.

The bug is in the script "simplify_network.py", ie. happens in the step when going from elec.nc to elec_s.nc. The function where the bug happens is "simplify_links", where chains of links (HVDC lines) are aggregated to one representative link (HVDC line).

@martacki martacki added the bug label Apr 7, 2020
@fneum
Copy link
Member

fneum commented Apr 7, 2020

So the solution would be to not aggregate links that cross countries? E.g.

IT ---link--- FR ---link--- IT

@martacki
Copy link
Member Author

martacki commented Apr 7, 2020

I was thinking how to fix it as well, and that would fix it only by accident. We wouldn't want Corsica to be aggregated to France "Festland" as well if the link was from Corsica to France... right? Is that because it's an island, or an own synchronous zone? Or both?

BTW, I think that there are more than this case were HVDC links are aggregated across country borders. simplify_links doesn't take countries & synchronous zones into account at all. Maybe that has to be added?

@euronion
Copy link
Contributor

euronion commented Apr 7, 2020

Is it an option to specifically state the cases, where the simplification should not happen, e.g. an exception list?
While it might not be the most elegant solution, it is usually easier to understand and guaranteed to not accidentally apply to buses where it should not apply to.

@martacki
Copy link
Member Author

martacki commented Apr 7, 2020

it would be definitely super easy to exclude this particular aggregation by removing the corresponding entry from the simplify_links_map. but doesn't fix all the other cases where we aggregate across country/synch-zone bounderies. I could check how many cases we're talking about here?

@nworbmot
Copy link
Member

nworbmot commented May 7, 2020

I don't know if this helps, but I noticed looking at the bus region shapes that Corsica is always aggregated to mainland France (even for 256 clusters), whereas Sardinia always remains its own synchronous area and a separate region. Perhaps something is going wrong with the country shapes?

@martacki martacki mentioned this issue May 28, 2021
10 tasks
@fneum
Copy link
Member

fneum commented May 1, 2022

@martacki do you have an overview if this is still the case or the issue can be closed?

@p-glaum
Copy link
Contributor

p-glaum commented Jun 9, 2022

@martacki is this issue solved?

@martacki
Copy link
Member Author

martacki commented Jun 9, 2022

@p-glaum no... but the work-around is rather ugly, and would add +1 node to the lowest resolution making it 38 nodes. we should discuss if we really want that.

edit: @fneum ooops, sorry missed your comment last month!

@fneum fneum closed this as not planned Won't fix, can't repro, duplicate, stale Feb 22, 2023
@fneum fneum reopened this Feb 22, 2023
fneum pushed a commit that referenced this issue Mar 6, 2023
Spatial management for solid biomass (transport)
@fneum
Copy link
Member

fneum commented Aug 14, 2024

Closed via #1215

@fneum fneum closed this as completed Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants