-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capacity Reduction for Kernnetz not necessary #174
Conversation
Validator ReportI am the Validator. Download all artifacts here. Variables comparison
MAPE: Mean Absolute Percentage Error General Files comparison
MAPE: Mean Absolute Percentage Error Comparing |
Looks good to me. @JulianGeis, please have a look if you agree with these changes, then the PR can be merged |
This makes sense. The kernnetz lines are already in capacity of hydrogen and need no more conversion. PR can be merged. |
In
prepare_sector_network
inadd_storage_and_grids
ifconfig["sector"]["H2_retrofit"]
the variablep_nom_extendable
is already multiplied by theoptions["H2_retrofit_capacity_per_CH4"]
factor.This means that multiplying it again in
modify_prenetwork
is not necessary.Only bugfix, so none of the points below are done.
Before asking for a review for this PR make sure to complete the following checklist:
ariadne_all
completes without errorsexport_ariadne_variables
has been adapted to the changesChangelog.md
main
has been merged into the PRYYYYMMDDdescriptive_title