Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capacity Reduction for Kernnetz not necessary #174

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

toniseibold
Copy link
Contributor

In prepare_sector_network in add_storage_and_grids if config["sector"]["H2_retrofit"] the variable p_nom_extendable is already multiplied by the options["H2_retrofit_capacity_per_CH4"] factor.
This means that multiplying it again in modify_prenetwork is not necessary.

Only bugfix, so none of the points below are done.

Before asking for a review for this PR make sure to complete the following checklist:

  • Workflow with target rule ariadne_all completes without errors
  • The logic of export_ariadne_variables has been adapted to the changes
  • One or several figures that validate the changes in the PR have been posted as a comment
  • A brief description of the changes has been added to Changelog.md
  • The latest main has been merged into the PR
  • The config has a new prefix of the format YYYYMMDDdescriptive_title

@toniseibold toniseibold requested a review from JulianGeis August 26, 2024 14:18
Copy link

github-actions bot commented Aug 26, 2024

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

Variables comparison
MAPE
Capacity Additions|Heat|Resistive heater 5529.61%
Capacity|Hydrogen|Reservoir 4609.49%
Capacity Additions|Hydrogen|Reservoir 926.63%
Secondary Energy|Heat|Oil 518.01%
Primary Energy|Oil|Heat 486.93%
Secondary Energy|Gases|Biomass 431.50%
Final Energy|Industry|Gases|Biomass 413.82%
Final Energy|Gases|Biomass 338.00%
Final Energy|Industry excl Non-Energy Use|Gases|Biomass 337.88%
Secondary Energy|Electricity|Oil 318.38%
Final Energy|Non-Energy Use|Gases|Biomass 240.47%
Primary Energy|Oil|Electricity 235.77%
Trade|Secondary Energy|Liquids|Hydrogen|Gross Import|Volume 169.62%
Secondary Energy|Liquids|Hydrogen 58.56%
Final Energy|Liquids|Efuel 58.53%
Final Energy|Transportation|Liquids|Efuel 58.50%
Final Energy|Industry|Liquids|Efuel 58.44%
Final Energy|Non-Energy Use|Liquids|Efuel 58.44%
Emissions|CO2|Energy|Production|From Liquids 58.39%
Final Energy|Industry excl Non-Energy Use|Liquids|Efuel 58.15%
Investment|Energy Supply|Heat|Resistive heater 41.67%
Primary Energy|Biomass|Gases 23.08%
Emissions|CO2|Energy|Production|From Gases 16.28%
Secondary Energy Input|Hydrogen|Electricity 10.09%
Final Energy|Residential and Commercial|Gases|Biomass 10.06%
Secondary Energy Input|Hydrogen|Heat 7.84%
Secondary Energy|Electricity|Hydrogen 7.73%
Secondary Energy|Heat|Hydrogen 6.62%
Capacity|Electricity|Hydrogen 5.32%
Capacity Additions|Electricity|Hydrogen 5.32%
Capacity Additions|Electricity|Hydrogen|FC 5.32%
Capacity|Electricity|Hydrogen|FC 5.32%

MAPE: Mean Absolute Percentage Error
Threshold: MAPE > 5%
Only variables reaching the threshold are shown. Find the equivalent plot for all of them below.

Variables changed plots
Main branch Feature branch
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
Error in loading image. Error in loading image.
General Plots comparison
Main branch Feature branch
Image not found in results Image not found in results
Image not found in results Image not found in results
Image not found in results Image not found in results
Image not found in results Image not found in results
Image not found in results Image not found in results
Image not found in results Image not found in results
General Files comparison
Numeric Status NMAE MAPE
csvs/curtailment.csv 72.2% ⚠️Changed 0.07 2.43e+03%
ariadne/exported_variables_full.xlsx ⚠️ NaN mismatch
ariadne/exported_variables.xlsx ⚠️ NaN mismatch
csvs/price_statistics.csv 57.1% ✅ Almost equal 0.11 1.2%
csvs/nodal_cfs.csv 63.5% ✅ Almost equal 0.00 45.9%
csvs/cfs.csv 71.8% ✅ Almost equal 0.00 92.9%
csvs/nodal_capacities.csv 64.2% ✅ Almost equal 0.00 5.74e+06%
csvs/cumulative_cost.csv 84.7% ✅ Almost equal 0.08 0.0%
csvs/nodal_supply_energy.csv 59.1% ✅ Almost equal 0.00 1.39e+07%
csvs/capacities.csv 72.2% ✅ Almost equal 0.01 6.29e+04%
csvs/energy.csv 72.6% ✅ Almost equal 0.02 1.45e+05%
csvs/costs.csv 64.7% ✅ Almost equal 0.02 1.18e+05%
csvs/supply.csv 64.3% ✅ Almost equal 0.01 3.16e+04%
csvs/supply_energy.csv 64.3% ✅ Almost equal 0.03 1.53e+05%
csvs/metrics.csv 54.5% ✅ Almost equal 0.06 1.8%
csvs/market_values.csv 76.7% ✅ Almost equal 0.06 1.7%
csvs/prices.csv 81.3% ✅ Almost equal 0.00 0.7%
csvs/nodal_costs.csv 57.8% ✅ Almost equal 0.00 9.36e+06%
csvs/weighted_prices.csv ✅ Equal

MAPE: Mean Absolute Percentage Error
NMAE: Mean Absolute Error on Min-Max Normalized Data
Status Threshold: NMAE > 0.05 and MAPE > 5%

Comparing fix_kernnetz (d8d4af5) with main (1eef9c6).
Branch is 1 commits ahead and 0 commits behind.
Last updated on 2024-08-26 18:56:57 CEST.

@lindnemi
Copy link
Collaborator

Looks good to me. @JulianGeis, please have a look if you agree with these changes, then the PR can be merged

@JulianGeis
Copy link
Contributor

This makes sense. The kernnetz lines are already in capacity of hydrogen and need no more conversion. PR can be merged.

@lindnemi lindnemi merged commit 00bc56e into main Sep 25, 2024
3 of 4 checks passed
@toniseibold toniseibold deleted the fix_kernnetz branch October 25, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants