Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set a more reasonable LC_ID_DYLIB entry on macOS #119

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Set a more reasonable LC_ID_DYLIB entry on macOS #119

merged 1 commit into from
Feb 18, 2021

Conversation

messense
Copy link
Member

Fixes #106

@messense messense mentioned this pull request Feb 18, 2021
Closed
@messense messense requested a review from davidhewitt February 18, 2021 14:17
davidhewitt
davidhewitt approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks very much for this!

@davidhewitt davidhewitt merged commit 8b35cc2 into PyO3:master Feb 18, 2021
@messense messense deleted the dylib-install-name branch February 19, 2021 00:01
@messense
Copy link
Member Author

@konstin We might want to do the same thing for maturin.

@konstin
Copy link
Member

konstin commented Feb 19, 2021

@messense Sounds good, unfortunately I don't have a mac so I can't myself

@messense messense mentioned this pull request Feb 19, 2021
Merged
@mathstuf
Copy link

mathstuf commented Mar 4, 2021

Could this be released so that wheels for cryptography with usable library IDs then be released? Alternatively, is there already a schedule in place I could track?

@davidhewitt
Copy link
Member

@mathstuf it'll be coming very soon - see #106 (comment)

@dependabot dependabot bot mentioned this pull request Mar 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rust binding in Cryptography 3.4+ dynamically links with non-existent library on macOS
4 participants
@messense @konstin @mathstuf @davidhewitt