initial migration of the trait bounds to IntoPyObject
(PyAnyMethods
)
#4480
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts the migration of the trait bounds to use
IntoPyObject
instead ofIntoPy
/ToPyObject
Test changes:
()
now turning into aPyTuple
both are expected by the new API.
I already added a small migration entry here, we can extend that when we migrate more APIs and implemented #4458. Same with the guide section.
Notable observation: Initially I tried to use
PyErr: From<T::Error>
as a bound on the APIs, but that caused inference issues of the associated type on the call site, so we should probably stick withInto
even tho it's a bit more verbose on the implementation site.