Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand guide on async methods borrowing self. #3636

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Expand guide on async methods borrowing self. #3636

merged 1 commit into from
Dec 14, 2023

Conversation

adamreichold
Copy link
Member

Following up on #3609 (comment)

@adamreichold
Copy link
Member Author

cc @wyfo

@adamreichold adamreichold added the CI-skip-changelog Skip checking changelog entry label Dec 9, 2023
wyfo
wyfo reviewed Dec 9, 2023
View reviewed changes
guide/src/async-await.md Outdated Show resolved Hide resolved
guide/src/async-await.md Outdated Show resolved Hide resolved
wyfo
wyfo reviewed Dec 9, 2023
View reviewed changes
guide/src/async-await.md Outdated Show resolved Hide resolved
@wyfo
Copy link
Contributor

wyfo commented Dec 9, 2023

👍 for me

@adamreichold adamreichold added this pull request to the merge queue Dec 14, 2023
@adamreichold adamreichold removed this pull request from the merge queue due to a manual request Dec 14, 2023
@adamreichold adamreichold added this pull request to the merge queue Dec 14, 2023
Merged via the queue into main with commit fc82c9f Dec 14, 2023
36 checks passed
@adamreichold adamreichold deleted the more-async-self-hints branch December 14, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyfo wyfo wyfo left review comments

Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamreichold @wyfo